[SYCL][TEST] Test to check ABI neutrality of SYCL RT #14492
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Steffen Larsen <[email protected]>
againull
changed the title
sergey-semenov
approved these changes
Jul 12, 2024
| // UNSUPPORTED: libcxx | ||
| // RUN: FileCheck %s --input-file %S/sycl_symbols_linux.dump | ||
|
|
||
| // The purpose of this test is to check that all symbols which are visible from |
There was a problem hiding this comment.
Suggested change
| // The purpose of this test is to check that all symbols which are visible from | |
| // The purpose of this test is to check that all symbols that are visible from |
| // with "cxx11" tag because such symbols correspond to the new ABI entries | ||
| // (_GLIBCXX_USE_CXX11_ABI=1, default) and won't work with a program that uses | ||
| // the old ABI (_GLIBCXX_USE_CXX11_ABI=0). All APIs exported from SYCL RT must | ||
| // avoid using classes like std::string and std::list impacted by dual-abi issue |
There was a problem hiding this comment.
Suggested change
| // avoid using classes like std::string and std::list impacted by dual-abi issue | |
| // avoid using classes impacted by the dual ABI issue like std::string and std::list |
| // (_GLIBCXX_USE_CXX11_ABI=1, default) and won't work with a program that uses | ||
| // the old ABI (_GLIBCXX_USE_CXX11_ABI=0). All APIs exported from SYCL RT must | ||
| // avoid using classes like std::string and std::list impacted by dual-abi issue | ||
| // and have to use abi-neutral counterpart provided by SYCL RT (e.g |
There was a problem hiding this comment.
Suggested change
| // and have to use abi-neutral counterpart provided by SYCL RT (e.g | |
| // and have to use their ABI-neutral counterparts provided by SYCL RT (e.g |
| // and have to use abi-neutral counterpart provided by SYCL RT (e.g | ||
| // sycl::detail::string, etc.). | ||
|
|
||
| // New exclusions are NOT ALLOWED to this file. All remaining cases which need |
There was a problem hiding this comment.
Suggested change
| // New exclusions are NOT ALLOWED to this file. All remaining cases which need | |
| // New exclusions are NOT ALLOWED to this file. All remaining cases that need |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.