[SYCL] kernel_compiler include file paths collision fix #14490
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cperkinsintel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
cperkinsintel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
| @@ -45,7 +52,7 @@ void ff_templated(T *ptr) { | |||
| sycl::nd_item<1> Item = sycl::ext::oneapi::this_work_item::get_nd_item<1>(); | |||
|
|
|||
| sycl::id<1> GId = Item.get_global_id(); | |||
| ptr[GId.get(0)] = GId.get(0) + 39; | |||
| ptr[GId.get(0)] = PlusEm(GId.get(0), 38); | |||
There was a problem hiding this comment.
Why 39 replaced with 38?
There was a problem hiding this comment.
Thanks @dm-vodopyanov ! There was a mistake in the test assertions and your question made me realize it existed. Fixed.
cperkinsintel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
cperkinsintel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
|
@dm-vodopyanov gentle ping |
smanna12
pushed a commit
to smanna12/llvm
that referenced
this pull request
Jul 16, 2024
kernel_compiler include_file support shouldn't have files that might collide. Spec has been recently clarified as well ( intel@a6d8758 )
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
kernel_compiler include_file support shouldn't have files that might collide. Spec has been recently clarified as well ( a6d8758 )