Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SYCL] Use SYCL 2020 exception in ext/oneapi/experimental/cuda/* #14484

Merged

Conversation

aelovikov-intel
Copy link
Contributor

No description provided.

Copy link
Contributor

@jchlanda jchlanda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code LGTM, but I don't know the rational behind it so it's hard to comment on that.

One thing to notice is that we move away form (previously defined) error code PI_ERROR_INVALID_DEVICE, but again, that might be OK, depending on the rationale behind the change.

@aelovikov-intel
Copy link
Contributor Author

The code LGTM, but I don't know the rational behind it so it's hard to comment on that.

One thing to notice is that we move away form (previously defined) error code PI_ERROR_INVALID_DEVICE, but again, that might be OK, depending on the rationale behind the change.

sycl::exception subclasses (like sycl::runtime_error) are SYCL 1.2 features and have been removed in SYCL 2020. As for the error code, I don't think it's right to create a PI error code out of thin air when it didn't come from the PI level.

@aelovikov-intel aelovikov-intel merged commit 49a1c42 into intel:sycl Jul 11, 2024
15 checks passed
@aelovikov-intel aelovikov-intel deleted the runtime_error_oneapi_cuda branch July 11, 2024 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants