-
Notifications
You must be signed in to change notification settings - Fork 715
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DeviceSanitizer][test] Update test to satisfy both libstdc++ and libc++ #14470
[DeviceSanitizer][test] Update test to satisfy both libstdc++ and libc++ #14470
Conversation
The outputs of libc++ and libstdc++ are not too much different, I think you can write a single “CHECK” to support both case, maybe need to use regexp, so that Filecheck needn't run twice. |
I think running FileCheck twice is not much of a problem here. And it won't be explicit as two possible matches and not be easy to extend the check to other possible results(although I don't think that would be needed). |
Okay, you decide this. |
Updated to use regex. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Hi @intel/llvm-gatekeepers , pls help merge this PR, thanks. |
Kindly ping @intel/llvm-gatekeepers again. |
The implementation of kernel name detangling is standard lib dependent, and both libstdc++ and libc++ are likely to be used, so we should make the test pass both with libstdc++ and libc++.