Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DeviceSanitizer][test] Update test to satisfy both libstdc++ and libc++ #14470

Conversation

yingcong-wu
Copy link
Contributor

The implementation of kernel name detangling is standard lib dependent, and both libstdc++ and libc++ are likely to be used, so we should make the test pass both with libstdc++ and libc++.

@AllanZyne
Copy link
Contributor

AllanZyne commented Jul 8, 2024

The outputs of libc++ and libstdc++ are not too much different, I think you can write a single “CHECK” to support both case, maybe need to use regexp, so that Filecheck needn't run twice.

@yingcong-wu
Copy link
Contributor Author

yingcong-wu commented Jul 8, 2024

I think running FileCheck twice is not much of a problem here. And it won't be explicit as two possible matches and not be easy to extend the check to other possible results(although I don't think that would be needed).

@AllanZyne
Copy link
Contributor

I think running FileCheck twice is not much of a problem here. And it won't be explicit as two possible matches and not be easy to extend the check to other possible results(although I don't think that would be needed).

Okay, you decide this.

@yingcong-wu
Copy link
Contributor Author

Updated to use regex.

Copy link
Contributor

@zhaomaosu zhaomaosu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@yingcong-wu
Copy link
Contributor Author

Hi @intel/llvm-gatekeepers , pls help merge this PR, thanks.

@yingcong-wu
Copy link
Contributor Author

Kindly ping @intel/llvm-gatekeepers again.

@sommerlukas sommerlukas merged commit b3e7606 into intel:sycl Jul 10, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants