Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add flag to swap references. #817

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

FurongZhang
Copy link
Contributor

There are different understanding of forward references(could be past frames or future frames) and backward references (could be past frames or future frames).

This flag allows the user to configure the reference as past or future frames.
- Value 0: by default, forward_references mean future frames, backward_references mean past frames
- Value 1: swap, forward_references mean past frames, backward_references mean future frames

Signed-off-by: Zhang, Furong <[email protected]>
@@ -989,11 +989,11 @@ typedef struct _VAProcPipelineParameterBuffer {
VABufferID *filters;
/** \brief Actual number of filters. */
uint32_t num_filters;
/** \brief Array of forward reference frames (past frames). */
/** \brief Array of forward reference frames (future frames by default). */
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

non-backward change

@ceyusa
Copy link
Contributor

ceyusa commented May 24, 2024

would be possible to the driver to ignore the swap request?

@FurongZhang
Copy link
Contributor Author

would be possible to the driver to ignore the swap request?

If the application does not need swap, the application can ignore the swap.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants