Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ipex llm upstream #33

Open
wants to merge 42 commits into
base: dev
Choose a base branch
from
Open

Ipex llm upstream #33

wants to merge 42 commits into from

Conversation

hkvision
Copy link
Collaborator

@hkvision hkvision commented Apr 8, 2024

@jason-dai @shane-huang @sgwhat Please take a look to see if this is appropriate for upstream.

https://github.com/oobabooga/text-generation-webui/wiki/Contributing-guidelines Seems no need to add tests. The style checks have been verified.

image

oobabooga and others added 11 commits February 14, 2024 11:32
* Add bigdl-llm loader

* Add BigDL-LLM if-else fork for encode

* Remove 'cpu-embedding' parameter

* Migrate source code to ipex-llm

* Add command-line flags for ipex-llm in readme
Edit description of options in GUI
* update style

* minor

* fix

* revert
@hkvision
Copy link
Collaborator Author

hkvision commented Apr 9, 2024

@jason-dai @shane-huang Removed some arguments, this is a cleaner version for upstream.

Copy link

@shane-huang shane-huang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally LGTM.

@@ -106,7 +106,7 @@

# bitsandbytes 4-bit
group = parser.add_argument_group('bitsandbytes 4-bit')
group.add_argument('--load-in-4bit', action='store_true', help='Load the model with 4-bit precision (using bitsandbytes).')
group.add_argument('--load-in-4bit', action='store_true', help='Load the model with 4-bit precision (using bitsandbytes or ipex-llm).')

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"using bitsandbytes or ipex-llm" is a bit confusing. Should we tell user in which case to use bitesandbytes and in which case ipex-llm?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No which case? If one is using bitsandbytes or ipex-llm, this argument will both take effect.

@shane-huang
Copy link

shall we mention how to use IPEX-LLM in webui somewhere? Need to modify some documents in webui?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants