feat : Support repository property for GitHub organization ruleset #2356
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactor logic to reduce the cognitive complexity and add logic to handle the repository_property field
Moser-ss
force-pushed
the
Support-repository_property-for-github_organization_ruleset
branch
from
bb62d7a
to
40c5111
Compare
Moser-ss
changed the title
1 task
|
@kfcampbell, could you take a quick look to see if I need to improve anything in this PR |
kfcampbell
reviewed
Sep 13, 2024
|
A test case was added, I hope the change was not to ugly |
|
@kfcampbell can I do anything to speed up the review of this PR? |
PaarthShah
reviewed
Oct 16, 2024
Comment on lines
+138
to
+140
| Elem: &schema.Schema{ | ||
| Type: schema.TypeString, | ||
| }, |
There was a problem hiding this comment.
Does this handle properties with boolean values? From a json export which shows the use of string "false" and "true" I assume it does
There was a problem hiding this comment.
I manualy tested the solution and can handle boelean custom_properties using strings
Refactor repository property conditions to make them optional Flatten update Target parameters to allow the detection of changes when remote resource is updated
Wait for the upgrade to go-github/v65/github to start use the source property
|
@Moser-ss I think you need to update the docs to reflect these changes? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #2137
Introduces the support to use
repository_propertyto target repositories in the rulesetThe changes were manually tested against a GitHub Organization with an enterprise plan.
It is not possible to add properties with the source system because the lib version doesn't allow that. It is necessary to update to version v65
Before the change?
repository_propertyAfter the change?
repository_propertyunder the conditions blockPull request checklist
Does this introduce a breaking change?
Please see our docs on breaking changes to help!