Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump go-github to v63 #2336

Merged
merged 1 commit into from
Aug 3, 2024
Merged

Conversation

Moser-ss
Copy link
Contributor

@Moser-ss Moser-ss commented Aug 2, 2024

Updates the dependency go-github from v62 to v63. Fix the breaking changes where CreateOrUpdateCustomRoleOptions has been renamed to CreateOrUpdateCustomRepoRoleOptions and roleID has been changed from type string to int64

The update is necessary to implement the feature requested in the issue #2137 because the repostiory_property is only available in the go-github v63


Before the change?

  • go-github@v62

After the change?

  • go-github@v63

Pull request checklist

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)

Does this introduce a breaking change?

Please see our docs on breaking changes to help!

  • Yes
  • No

Copy link
Member

@kfcampbell kfcampbell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure why the new merge UI isn't giving me the chance to approve automated checks, but this builds and lints successfully for me locally. There's a test failure that also crept into the main branch somehow and is unrelated.

Thank you!

@kfcampbell kfcampbell merged commit 5345c40 into integrations:main Aug 3, 2024
1 check passed
@Moser-ss Moser-ss deleted the bump-go-github-v63 branch August 5, 2024 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants