feat: support team organization role assignment #2322
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
felixlut
commented
Jul 17, 2024
| } | ||
|
|
||
| octokitClient, err := pkg.NewApiClient( | ||
| // pkg.WithUserAgent("my-user-agent"), // Should this be set to terraform-provider-github or similar? Doesn't look like the user-agent is set for the other clients |
There was a problem hiding this comment.
Seems like the provider is not setting the user-agent for the other clients, but maybe it should?
felixlut
commented
Jul 17, 2024
| } | ||
|
|
||
| // There is no api for checking a specific team role assignment, so instead we iterate over all teams assigned to the role | ||
| // go-github pagination (https://github.com/google/go-github?tab=readme-ov-file#pagination) |
There was a problem hiding this comment.
Using google/go-github here instead of octokit/go-sdk since the former doesn't support pagination
felixlut
commented
Jul 17, 2024
|
|
||
| randomID := acctest.RandStringFromCharSet(5, acctest.CharSetAlphaNum) | ||
|
|
||
| // Using the predefined roles since custom roles are a strictly Enterprise feature ((https://github.blog/changelog/2024-07-10-pre-defined-organization-roles-that-grant-access-to-all-repositories/)) |
There was a problem hiding this comment.
Since custom organization roles are a Enterprise level feature, I have elected to not use them in the tests and instead use the built-in roles instead. I've created a manual mapping for their role_id:s here. Not ideal, but I don't have a better way of testing this
|
Looking forward to this feature! Any thoughts on when it might be implemented? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #2314
Before the change?
After the change?
github_team_organization_role_assignmentresource which is used to assign an organization role to a teamoctokit/go-sdksincegoogle/go-githublacked support for assigning a role to a team as far as I could see. go-github is still being used for this resource though, as go-sdk lacks support for pagination (Allow to easily use GitHub Pagination. microsoft/kiota#4698), which is needed in the READ implementationFiles changedtab lags... https://github.com/orgs/community/discussions/39341Pull request checklist
Does this introduce a breaking change?
Please see our docs on breaking changes to help!