WIP: support repository_custom_properties resource and datasource #2316
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 15, 2024
|
@felixlut It seems that v64 google/go-github#3240 added support for Multi select finally. Only issue is that the terraform provider codebase is still at v63 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1956 (doesn't resolve that whole issue, but contributes to it)
Custom properties are defined on an organizational level, and then applied on a repository level. This PR aims to solve the latter of those two, while the former already has a PR for it in #2107.
This is a work in progress (WIP) since the underlying sdk:s are lacking for the REST endpoints pertaining to the repository level custom properties:
go-githublacks support for themulti_selectcustom property type, see Bug: Multi-select Custom Properties are not supported google/go-github#3198. There is a PR close to being merged for solving this feat!: Add support for multi-select Custom Properties google/go-github#3200go-githubhas been released sincegithub_repository_custom_propertiesdatasource with it due to the lacking functionality ofgo-githubin this area currently. I'm currently trying to get it to write the custom properties, which I've been unsuccessful in so far. See [BUG]: PATCH request for repos/OWNER/REPO/properties/values broken octokit/go-sdk#90github_repository_custom_propertiesdatasource togithub_repository_custom_property(notice propertIES --> propertY), which fetches a specific property instead of all of them after discussion in 🏳️ Custom properties resource & data #2107 (comment)If there's any progress on either of these I'll update this PR
Before the change?
After the change?
Pull request checklist
Does this introduce a breaking change?
Please see our docs on breaking changes to help!