Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add https_enforced GH Pages setting #2277

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

matijs
Copy link

@matijs matijs commented May 29, 2024

Resolves #2276


Before the change?

  • n/a

After the change?

  • it's possible to set https_enforced

Pull request checklist

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)

Does this introduce a breaking change?

Please see our docs on breaking changes to help!

  • Yes
  • No

@matijs
Copy link
Author

matijs commented May 30, 2024

It looks like this is a little more involved and depends on cname being set. For Pages sites without a custom domain, https is always enforced.

@matijs matijs force-pushed the feat/gh-pages-https-enforced branch from 30cc5c2 to 7bdf262 Compare May 30, 2024 16:31
@matijs
Copy link
Author

matijs commented May 30, 2024

It looks like this is a little more involved and depends on cname being set. For Pages sites without a custom domain, https is always enforced.

Updated the PR accordingly.

@matijs matijs changed the title feat: add https_enforced GH Pages setting feat: add https_enforced GH Pages setting Jun 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEAT]: Support the https_enforced setting for GitHub Pages
1 participant