Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fixes an issue when using signed commits #157

Closed
wants to merge 2 commits into from

Conversation

luislard
Copy link
Contributor

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes/features)
  • Docs have been added/updated (for bug fixes/features)

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Fix

What is the current behavior? (You can also link to an open issue here)
When using copy pasted config from docs to get signed commits and the NPM_REGISTRY_TOKEN the workflow is not able to release the package to private npm

What is the new behavior (if this is a feature change)?
The package is pushed to the npm registry

Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
No

Other information:

@luislard
Copy link
Contributor Author

Closed because the issue we were having was related to an expired token and not to the workflow.

@luislard luislard closed this Sep 13, 2024
@luislard luislard deleted the fix_npm_publish_in_automatic_release branch September 13, 2024 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant