Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated tests to run on php 8.4 from 8.3, #PG-3957 #64

Merged
merged 1 commit into from
Nov 5, 2024
Merged

Updated tests to run on php 8.4 from 8.3, #PG-3957 #64

merged 1 commit into from
Nov 5, 2024

Conversation

snake14
Copy link
Contributor

@snake14 snake14 commented Nov 5, 2024

Description:

Updated tests to run on php 8.4 from 8.3, #PG-3957

Review

  • Functional review done
  • Potential edge cases thought about (behavior of the code with strange input, with strange internal state or possible interactions with other Matomo subsystems)
  • Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
  • Security review done see checklist
  • Code review done
  • Tests were added if useful/possible
  • Reviewed for breaking changes
  • Developer changelog updated if needed
  • Documentation added if needed
  • Existing documentation updated if needed

@snake14 snake14 merged commit da72bc1 into 5.x-dev Nov 5, 2024
6 checks passed
@snake14 snake14 deleted the PG-3957-php-8.4-upgrade branch November 5, 2024 01:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@snake14 @AltamashShaikh