Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consolidation of pipelines #209

Merged
merged 9 commits into from
Dec 13, 2023
Merged

Consolidation of pipelines #209

merged 9 commits into from
Dec 13, 2023

Conversation

jorwoods
Copy link
Collaborator

@jorwoods jorwoods commented Dec 11, 2023 •
edited
Loading

This PR makes several changes to streamline the PR and publish pipelines.

  1. Remove wheels.yml.
  2. pythonpackage.yml now runs the pre-commit hooks, pytest tests, and build checks on various platforms by incorporating the stpes from cibuildwheel. The build is only done in this pipeline to ensure the build can run successfully, and the artifacts are in effect discarded.
  3. Some steps that appeared to be redundant were removed from pythonpackage.yml. It appeared to me that these cases would be covered by the os matrix defined in the yml and by the version matrix defined in pyproject.toml.
  4. pypi_publish.yml now when a new tag is pushed to the repo will run pytest, build the wheels, and publish to PyPI.

WillAyd
WillAyd reviewed Dec 11, 2023
View reviewed changes
Copy link
Collaborator

@WillAyd WillAyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just to confirm how this works can you make a test fail? Just want to make sure it still gives useful output to developers when that happens

.github/workflows/pythonpackage.yml Outdated Show resolved Hide resolved
WillAyd
WillAyd approved these changes Dec 13, 2023
View reviewed changes
Copy link
Collaborator

@WillAyd WillAyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very nice - I like how this looks!

@WillAyd WillAyd merged commit 89f66c1 into innobi:main Dec 13, 2023
8 checks passed
@WillAyd
Copy link
Collaborator

WillAyd commented Dec 13, 2023

Great thanks @jorwoods

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WillAyd WillAyd WillAyd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jorwoods @WillAyd