Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(agent.buffer): Fix shared wal file between same named plugins #15966

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

DStrand1
Copy link
Member

@DStrand1 DStrand1 commented Oct 2, 2024

Summary

Includes the alias (if set) in the file path for the WAL file to avoid plugins named the same sharing a WAL file and causing race conditions

Checklist

  • No AI generated code was used in this PR

Related issues

resolves #15876

@DStrand1 DStrand1 added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label Oct 2, 2024
@telegraf-tiger
Copy link
Contributor

telegraf-tiger bot commented Oct 2, 2024

Thanks so much for the pull request!
🤝 ✒️ Just a reminder that the CLA has not yet been signed, and we'll need it before merging. Please sign the CLA when you get a chance, then post a comment here saying !signed-cla

@telegraf-tiger telegraf-tiger bot added the fix pr to fix corresponding bug label Oct 2, 2024
@DStrand1
Copy link
Member Author

DStrand1 commented Oct 2, 2024

!signed-cla

@telegraf-tiger
Copy link
Contributor

telegraf-tiger bot commented Oct 2, 2024

Copy link
Member

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@DStrand1 I don't think this will fix the issue as you now require the user to set an alias! It would be better to use the plugin ID instead as it is actually unique per plugin...

@DStrand1 DStrand1 assigned DStrand1 and unassigned srebhan Oct 2, 2024
@DStrand1 DStrand1 removed the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix pr to fix corresponding bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Telegraf crashes when buffer_strategy = "disk" and more than one output plugin of the same type is configured
2 participants