feat: configurable last cache eviction #25520
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This changes how the last cache is evicted. It will no longer run eviction on writes to the cache, instead, there is an optional method to create a last cache provider that will run eviction in a background task on a specified interval. Otherwise, when records are produced from the cache, only those that have not expired will be produced. This should reduce locks on the cache and hopefully improve performance.
hiltontj
commented
Nov 6, 2024
There was a problem hiding this comment.
The changes here are the key to fixing the performance issue. This:
- Does not run eviction on every buffered WAL batch
- Does not hold a lock on the write buffer while populating the last cache
pauldix
approved these changes
Nov 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #25519
This alters the eviction behaviour of the last-n-value cache:
LastCacheProvideris now run in the background, by default, every1m, but the interval can be configured by the user on server start with the--last-cache-eviction-intervalargument.