-
Notifications
You must be signed in to change notification settings - Fork 187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: catch CancelledError and TimeoutError and add note about timeout #679
Conversation
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #679 +/- ##
==========================================
- Coverage 90.49% 90.36% -0.13%
==========================================
Files 40 40
Lines 3534 3539 +5
==========================================
Hits 3198 3198
- Misses 336 341 +5 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
@@ -1,6 +1,6 @@ | |||
"""Parsing response from InfluxDB to FluxStructures or DataFrame.""" | |||
|
|||
|
|||
import asyncio |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sync
client doesn't include asyncio
library. You have to check the type by name... maybe something like:
elif 'DataFrame' in type(record).__name__: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated to catch BasicException
and then check type. import asyncio
removed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
Closes #671
Proposed Changes
in
flux_csv_parser
catchCancelledError
andTimeoutError
and add a note to check the clienttimeout
setting.Checklist
pytest tests
completes successfully