Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: linting at flux_table.py #677

Merged
merged 4 commits into from
Oct 8, 2024
Merged

Conversation

youarecode
Copy link
Contributor

@youarecode youarecode commented Oct 7, 2024

Closes #674

Proposed Changes

class FluxTable(FluxStructure):
    def __init__(self) -> None:
        self.columns: List[FluxColumn] = [] #<<<<---- Added this typing
        self.records: List[FluxRecord] = []    #<<<<---- Added this typing

Testing found the following warnings:

  1. duplicated import
#setup.py
from pathlib import Path
from pathlib import Path #<<<<-------------deleted duplicated

NOTE

There's still unrelated tests that are not passing
make lint

Checklist

  • CHANGELOG.md updated
  • Rebased/mergeable
  • A test has been added if appropriate
  • pytest tests completes successfully
  • Commit messages are conventional
  • Sign CLA (if not already signed)

@codecov-commenter
Copy link

codecov-commenter commented Oct 7, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.47%. Comparing base (3d70dbd) to head (fabc9da).
Report is 1 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #677   +/-   ##
=======================================
  Coverage   90.47%   90.47%           
=======================================
  Files          40       40           
  Lines        3528     3528           
=======================================
  Hits         3192     3192           
  Misses        336      336           
Flag Coverage Δ
?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@bednar bednar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@youarecode thanks for your PR 👍

LGTM 🚀

@bednar bednar merged commit 28a4a04 into influxdata:master Oct 8, 2024
15 checks passed
@bednar bednar added this to the 1.47.0 milestone Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

flux_table.py Linting (Bug and FIX)
3 participants