Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(dataframe): avoid chained assignment in replace operation #638

Conversation

mattbrth
Copy link
Contributor

@mattbrth mattbrth commented Jan 31, 2024

Closes #637

Proposed Changes

  • Refactor DataFrame operations to avoid chained assignment and resolve FutureWarning in pandas.
  • Ensure compatibility with upcoming changes in pandas 3.0.

Checklist

  • CHANGELOG.md updated
  • Rebased/mergeable
  • A test has been added if appropriate
  • pytest tests completes successfully
  • Commit messages are conventional
  • Sign CLA (if not already signed)

@codecov-commenter
Copy link

codecov-commenter commented Jan 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7a5f655) 90.40% compared to head (8c2775c) 90.40%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #638   +/-   ##
=======================================
  Coverage   90.40%   90.40%           
=======================================
  Files          39       39           
  Lines        3503     3503           
=======================================
  Hits         3167     3167           
  Misses        336      336           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mattbrth mattbrth force-pushed the MattBrth/pandas3-compatibility-dataframe-serializer branch from 611bcb3 to 8c2775c Compare January 31, 2024 20:14
Copy link
Contributor

@bednar bednar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mattbrth thanks for your PR 👍

LGTM 🚀

@mattbrth
Copy link
Contributor Author

mattbrth commented Feb 1, 2024

Sure, no problem ! However it doesn't solve #613 @bednar

@bednar bednar merged commit 2d91db5 into influxdata:master Feb 1, 2024
16 checks passed
@bednar bednar added this to the 1.41.0 milestone Feb 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor DataFrame Operations to Avoid Chained Assignment and Address FutureWarning in Pandas
3 participants