Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: task pagination #616

Merged
merged 8 commits into from
Nov 29, 2023
Merged

feat: task pagination #616

merged 8 commits into from
Nov 29, 2023

Conversation

Sciator
Copy link
Contributor

@Sciator Sciator commented Nov 21, 2023

Closes #614

Proposed Changes

added tasks_api.find_tasks_iter

Checklist

  • CHANGELOG.md updated
  • Rebased/mergeable
  • A test has been added if appropriate
  • pytest tests completes successfully
  • Commit messages are conventional
  • Sign CLA (if not already signed)

@Sciator

This comment was marked as resolved.

@Sciator Sciator force-pushed the feat-task-pagination branch from 0b03780 to 213860d Compare November 22, 2023 09:05
@codecov-commenter
Copy link

codecov-commenter commented Nov 22, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (2f9e5ed) 90.30% compared to head (ae2c18b) 90.35%.

Files Patch % Lines
influxdb_client/client/tasks_api.py 94.59% 2 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #616      +/-   ##
==========================================
+ Coverage   90.30%   90.35%   +0.04%     
==========================================
  Files          39       39              
  Lines        3456     3493      +37     
==========================================
+ Hits         3121     3156      +35     
- Misses        335      337       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Sciator Sciator requested a review from bednar November 22, 2023 12:41
@bednar bednar changed the title feat: taks pagination feat: task pagination Nov 23, 2023
Copy link
Contributor

@bednar bednar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your PR! 👍 Before we can accept it, there are a few requirements that need to be met:

influxdb_client/client/tasks_api.py Outdated Show resolved Hide resolved
influxdb_client/client/tasks_api.py Outdated Show resolved Hide resolved
influxdb_client/client/tasks_api.py Outdated Show resolved Hide resolved
influxdb_client/client/tasks_api.py Outdated Show resolved Hide resolved
influxdb_client/client/tasks_api.py Outdated Show resolved Hide resolved
@Sciator Sciator requested a review from bednar November 27, 2023 08:52
Copy link
Contributor

@bednar bednar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@bednar bednar merged commit 0c60b5d into master Nov 29, 2023
14 checks passed
@bednar bednar deleted the feat-task-pagination branch November 29, 2023 11:22
@bednar bednar added this to the 1.39.0 milestone Nov 29, 2023
@mbenabda mbenabda mentioned this pull request May 24, 2024
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Restore paging on find Tasks api
3 participants