Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: implement general fixes #643

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

chore: implement general fixes #643

wants to merge 8 commits into from

Conversation

bnpfeife
Copy link
Contributor

@bnpfeife bnpfeife commented Sep 1, 2022

No description provided.

@bnpfeife bnpfeife self-assigned this Sep 1, 2022
@bnpfeife bnpfeife force-pushed the BNP_general_fixes branch 2 times, most recently from b448b96 to bd795b3 Compare September 1, 2022 21:33
powersj
powersj reviewed Sep 2, 2022
View reviewed changes
Copy link
Contributor

@powersj powersj left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sspaink any issues with changing up these files and our automation?

@bnpfeife - I realize this is a draft, but left some comments for telegraf. Thanks for doing this!

@bnpfeife
Copy link
Contributor Author

bnpfeife commented Sep 2, 2022

@bnpfeife - I realize this is a draft, but left some comments for telegraf. Thanks for doing this!

Hey, thanks for taking a look at it! I replied to some of the comments. If there are still concerns, I am definitely open to reverting the changes to Telegraf (or anything else) before this gets finalized. My main goal with this is to simplify the Dockerfiles a bit and resolve non-determinism with the builds.

@bnpfeife bnpfeife marked this pull request as ready for review September 6, 2022 16:31
@powersj
Copy link
Contributor

powersj commented Sep 7, 2022

Thanks for the replies!

Hipska
Hipska approved these changes Apr 14, 2023
View reviewed changes
Copy link
Contributor

@Hipska Hipska left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approval for the telegraf related files, didn't check the others..

Question: The fixes only seems to be for 1.21 to 1.23 (which don't exist anymore in current master), what about the newer versions? They don't need these fixes or are already fixed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@powersj powersj powersj left review comments

@Hipska Hipska Hipska approved these changes

Assignees

@bnpfeife bnpfeife

Labels
chronograf influxdb kapacitor telegraf
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bnpfeife @powersj @Hipska