Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(print): add style options for tables #736

Merged
merged 1 commit into from
Sep 3, 2021
Merged

feat(print): add style options for tables #736

merged 1 commit into from
Sep 3, 2021

Conversation

PauloRSF
Copy link
Contributor

This adds the ability to pass a style property on print.table's options, as requested on #724 (although it still doesn't fully achieve what the issue's author wanted).

  • Created new type TableStyle
  • Added style prop on GluegunPrintTableOptions
  • Modified markdown table formatting to correctly print columns header dividers when padding is applied
  • Updated tests and docs accordingly

jamonholmgren
jamonholmgren approved these changes Sep 3, 2021
View reviewed changes
Copy link
Member

@jamonholmgren jamonholmgren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! This is great. Thank you!

@jamonholmgren jamonholmgren merged commit 58816e3 into infinitered:master Sep 3, 2021
@jamonholmgren
Copy link
Member

jamonholmgren commented Sep 3, 2021 •
edited
Loading

Apologies for not seeing this earlier. I think it got lost in my notifications.

infinitered-circleci pushed a commit that referenced this pull request Sep 3, 2021
@semantic-release-bot
chore(release): 4.7.0 [skip ci]
35d2e70 
# [4.7.0](v4.6.1...v4.7.0) (2021-09-03)

### Features

* **print:** add style options for tables ([#736](#736) by @PauloRSF) ([58816e3](58816e3))
@infinitered-circleci
Copy link

🎉 This PR is included in version 4.7.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jamonholmgren jamonholmgren jamonholmgren approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@PauloRSF @jamonholmgren @infinitered-circleci