Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

支持由两个char组成的Surrogate Pair(比如生僻字、自造字、emoji等) #1071

Merged
merged 3 commits into from
Aug 27, 2024

Conversation

yangzhongke
Copy link
Contributor

@yangzhongke yangzhongke commented Aug 21, 2024

对于由两个char组成的Surrogate Pair(比如生僻字、自造字、emoji等)进行支持。
测试用字符串:
"又見菩\uDB84\uDD2E,處林放光,濟地獄苦,令入佛\uDB84\uDC01。又見佛子\uD83D\uDE00\uD83D\uDE43龟龙麟凤剃\uDB84\uDC97鬚髪。或見菩\uDB84\uDCA7做张做势牛哈"

这个PR可以解决如下几个issue:
1)#1067
2)#1068
3) #718

@yangzhongke yangzhongke marked this pull request as ready for review August 21, 2024 11:45
@medcl
Copy link
Member

medcl commented Aug 22, 2024

@yangzhongke 你好,谢谢你提交 PR,测试的部分可以换成单元测试来进行么?

@yangzhongke
Copy link
Contributor Author

@medcl
谢谢回复,目前项目里还没有单元测试吧?您对于单元测试有什么建议?比如代码放到哪个文件夹下?是否启用github action实现PR自动运行单元测试?
如果确实还没有单元测试的话,我能否先把这个Test.java从这个PR中删掉,然后先把这个PR合并。
然后我再创建一个单独的PR来增加单元测试以及GitHub Actions?

@yangzhongke
Copy link
Contributor Author

@medcl Test.java已经删除,准备把它转换为单元测试,然后放到单独的PR中提交

yangzhongke added a commit to tripitakas/analysis-ik that referenced this pull request Aug 26, 2024
@medcl medcl merged commit 8a9f2bf into infinilabs:master Aug 27, 2024
@medcl
Copy link
Member

medcl commented Aug 27, 2024

Thanks~

@ivalue2333
Copy link

请问下这个实现支持颜文字吗

@yangzhongke
Copy link
Contributor Author

颜文字

颜文字本质上就是多个char了,你把多个char当成一个单词录入词库就行了。和我这个没有直接关系。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants