Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor rendergraph #533

Draft
wants to merge 179 commits into
base: main
Choose a base branch
from
Draft

Refactor rendergraph #533

wants to merge 179 commits into from

Conversation

IAmNotHanni
Copy link
Member

@IAmNotHanni IAmNotHanni commented May 12, 2023

Once this gets merged, we should release v0.1-alpha.4

  • REBASE ONTO MAIN!

Major Changes

Minor Changes

  • Throw exception if name is empty in every RAII wrapper class
  • Do not call .reset() explicitely before smart pointer reassignment (this is redundant)

Outlook (rendergraph3)

  • Automatic double or triple buffering of all rendergraph resources to manage frames in flight automatically
  • Parallelize Command Buffer recording
  • Vulkan performance query pools
  • Improve barrier placement
  • Improve VkWriteDescriptorSet updating mechanism
  • Pre-fill VkRenderingAttachmentInfo instead of doing it per-frame
  • Internal descriptor performance metrics based on cmd_buf.bind_descriptor_set wrapper function
  • SPIR-V shader metadata reflection by parsing with SPIRV-Cross
  • Maybe rendergraph can reason about descriptor pool sizes ahead of descriptor pool allocation?
  • Batch calls to vkCreateGraphicsPipelines (How to work this into GraphicsPipelineBuilder and ? (GraphicsPass wrapper?)
  • Debatable: Implement a PipelineBarrierBatchBuilder? (Real use might not be significant)
  • Check limits of VkPhysicalDevicewith respect to rendergraph setup?

@IAmNotHanni IAmNotHanni added cat:refactor refactor/clean up/simplifications/etc. feat:rendering rendering labels May 12, 2023
@IAmNotHanni IAmNotHanni self-assigned this May 12, 2023
@IAmNotHanni IAmNotHanni force-pushed the hanni/rendergraph2 branch 6 times, most recently from dad7478 to 37a0506 Compare May 18, 2023 12:23
@IAmNotHanni IAmNotHanni added the prio:high This has high priority. label May 20, 2023
@IAmNotHanni IAmNotHanni force-pushed the hanni/rendergraph2 branch 4 times, most recently from d23d14d to 6afd9a1 Compare May 20, 2023 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cat:refactor refactor/clean up/simplifications/etc. feat:rendering rendering prio:high This has high priority.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant