This repository has been archived by the owner on Dec 14, 2021. It is now read-only.
Fix CustomEvent Implementation #152
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mouvedia
reviewed
Dec 4, 2018
dom.js
Outdated
| return; | ||
| function CustomEvent ( event, params ) { | ||
| params = params || { bubbles: false, cancelable: false, detail: undefined }; | ||
| var evt = document.createEvent( 'CustomEvent' ); | ||
| var evt = creteCustomEvent(); |
Currently `new CustomEvent('!').constructor === CustomEvent` returns false, which is a hell of a bummer for anything else that is either polyfilling or feature detecting CustomEvent after this file is on the page.
Bonus: I have removed the redundant `in` check when `typeof` is all it's needed.
Please consider publishing this fix ASAP since it's conflicting with other polyfills.
Thank you.
WebReflection
force-pushed
the
patch-1
branch
from
caf79ec
to
c58a49d
Compare
You will have to wait for @inexorabletash's review. |
|
will that ever happen? |
|
Please add a test case, then I can merge. |
|
The test case is in the ticket:
I'm on vacation 'till 26th so I won't change this PR before that day. |
|
Common @WebReflection just add one line there if you don't want to create another test case. |
|
I'm not lazy, I'm on vacation without internet and my laptop not always with me. |
|
With the patch applied, this fails in IE11: assert.ok(new CustomEvent('!').constructor === CustomEvent); |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently
new CustomEvent('!').constructor === CustomEventreturnsfalsein IE11, which is a hell of a bummer for anything else that is either polyfilling or feature detecting CustomEvent after this file is on the page.Bonus: I have removed the redundant
incheck whentypeofis all it's needed.Please consider publishing this fix ASAP since it's conflicting with other polyfills.
Thank you.