Import dark theme from https://github.com/dennis84/codemirror-themes/…

[peepeetee]

…blob/main/theme/github-dark.ts

Import dark theme from https://github.com/dennis84/codemirror-themes/blob/main/theme/github-dark.ts

The correct solution here is to go back to https://discuss.codemirror.net/t/dynamic-light-mode-dark-mode-how/4709/5 and look at the solution: https://discuss.codemirror.net/t/dynamic-light-mode-dark-mode-how/4709/2

The idea is to use the default theme implementation and not use the compatibility bodge. This would probably involve including some theme files in the source, and I would prefer a theme picker as shown https://codemirror.net/5/demo/theme.html ( this is codemirror5 but you get the idea)

[inducer]

Thanks! And d'oh! Just last night I also pushed a fix for #1084, in b3d1181. Would you still prefer the Github theme? I'd be happy to bring it in if you think it's a net win.

I thought about a theme picker. (Probably we'd need two: one for dark and one for light.) That's a slightly bigger change, but manageable. If you'd like it, file an issue?

[peepeetee]

Thanks! And d'oh! Just last night I also pushed a fix for #1084, in b3d1181. Would you still prefer the Github theme? I'd be happy to bring it in if you think it's a net win.

I thought about a theme picker. (Probably we'd need two: one for dark and one for light.) That's a slightly bigger change, but manageable. If you'd like it, file an issue?

Yee, I had to delete my browser cache but I can confirm that it is working now.

I have converted this pr to a draft, not sure how to convert it to an issue. I could close it and open a new issue if you want

[inducer]

New issue sounds good if what you'd like to request is unrelated to this PR.

[peepeetee]

New issue sounds good if what you'd like to request is unrelated to this PR.

#1134