Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tag propagation logic #494

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

a-alveyblanc
Copy link
Contributor

@a-alveyblanc a-alveyblanc commented Apr 22, 2024

  • Move tag propagation graph generation to pytools
  • Respect IgnoredForPropagationTag in tag propagation

requirements.txt Show resolved Hide resolved
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add example using tensor product axes

@a-alveyblanc
Copy link
Contributor Author

Looks like pylint and mypy are failing even though the changes in inducer/pytools#220 have been merged. They don't fail locally 🤷‍♂️

@inducer
Copy link
Owner

inducer commented Sep 5, 2024

Needs a pytools release, I'll make one.

@inducer
Copy link
Owner

inducer commented Sep 5, 2024

@inducer
Copy link
Owner

inducer commented Sep 5, 2024

We should add a dependency on that version in pyproject.toml.

@a-alveyblanc
Copy link
Contributor Author

a-alveyblanc commented Sep 5, 2024

Added dependency on pytools 2024.1.14 to setup.py. It seems like that's where other project information lives, and adding dependencies to pyproject.toml prevented pytato from installing during tests.

# }}}


class IgnoredForPropagationTag(Tag):
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Include in docs.
  • Explain the semantics.
  • Add a use case/justification for why one might possibly want this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants