Add axis tags for reshapes, etc., in direction connection code #379
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
majosm
force-pushed
the
direct-connection-axis-tags
branch
from
d22b588
to
d10a41f
Compare
majosm
force-pushed
the
direct-connection-axis-tags
branch
from
af5fc83
to
8e0c041
Compare
majosm
force-pushed
the
direct-connection-axis-tags
branch
from
8e0c041
to
64cf45d
Compare
majosm
force-pushed
the
direct-connection-axis-tags
branch
from
64cf45d
to
9e8d6fa
Compare
inducer
reviewed
Jul 28, 2023
| @@ -553,17 +556,22 @@ def _per_target_group_pick_info( | |||
| _FromGroupPickData( | |||
| from_group_index=source_group_index, | |||
| dof_pick_lists=actx.freeze( | |||
There was a problem hiding this comment.
I think it would suffice to just tag the element axis in the indirect access where this is used, below.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are part of what was causing the fallback warnings while compiling the Y3 prediction case.