Provide details for IdentityRetrievalFailed exception

indico · Nov 21, 2024 · 7f1d7ee · 7f1d7ee
1 parent 8940483
commit 7f1d7ee
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 4 deletions.
diff --git a/flask_multipass/providers/authlib.py b/flask_multipass/providers/authlib.py
@@ -175,5 +175,5 @@ def get_identity_from_auth(self, auth_info):
         identifier = auth_info.data.get(self.id_field)
         if not identifier:
             raise IdentityRetrievalFailed(f'Identifier ({self.id_field}) missing in authlib response',
-                                          provider=self)
+                                          details=auth_info.data, provider=self)
         return IdentityInfo(self, identifier=identifier, **auth_info.data)
diff --git a/flask_multipass/providers/saml.py b/flask_multipass/providers/saml.py
@@ -193,8 +193,10 @@ def get_identity_from_auth(self, auth_info):
         identifier = auth_info.data.get(self.id_field)
         if isinstance(identifier, list):
             if len(identifier) != 1:
-                raise IdentityRetrievalFailed('Identifier has multiple elements', provider=self)
+                raise IdentityRetrievalFailed('Identifier has multiple elements', 
+                                              details=identifier, provider=self)
             identifier = identifier[0]
         if not identifier:
-            raise IdentityRetrievalFailed('Identifier missing in saml response', provider=self)
+            raise IdentityRetrievalFailed('Identifier missing in saml response', 
+                                          details=auth_info.data, provider=self)
         return IdentityInfo(self, identifier=identifier, **auth_info.data)
diff --git a/flask_multipass/providers/shibboleth.py b/flask_multipass/providers/shibboleth.py
@@ -86,5 +86,6 @@ def __init__(self, *args, **kwargs):
     def get_identity_from_auth(self, auth_info):
         identifier = auth_info.data.get(self.id_field)
         if not identifier:
-            raise IdentityRetrievalFailed('Identifier missing in shibboleth response', provider=self)
+            raise IdentityRetrievalFailed('Identifier missing in shibboleth response', 
+                                          details=auth_info.data, provider=self)
         return IdentityInfo(self, identifier=identifier, **auth_info.data)