-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEATURE] Fingerprint migration #49
base: develop
Are you sure you want to change the base?
Conversation
Thx Felix, I'm going to test this issue as soon as possible :) |
Thx Felix, I'm just playing a bit with the new library. In my case fingerprint values are calculated with this properties:
In FireFox one single warning is still listed: |
to get a string with 32 characters as before
@felixranesberger I just pushed a small update with a small fix. In addition a md5 function is used for hashing the short string (e.g. "17gwjmp") to 32 character lenghts again (because this is an important part in backend functionality). |
I thought using
Maybe I'm using the function incorrectly. I'll have a look tomorrow. |
I found this issue where they discuss this warning. |
Regarding the |
Of course we could but this is a bigger change that you might guess. At the moment it's kind of hardcoded that 32 character strings are fingerprints while 33 character strings are local storage values. In general: I think the thumbmarkjs library is a good solution and we should go for it. I will discuss this with @lefloe in the next LUX meeting Thank you very much so far |
I think this is a pretty good solution. |
…g, but avoid using unnecessary md5 hashing function
0f62041
to
47dfa80
Compare
With the new commit I added this line: const computedFingerprint = `${'0'.repeat(32 - fingerprint.length)}${fingerprint}`; It makes sure to fill the remaining space to 32 character length with zeros. |
71f6c7d
to
cf52572
Compare
No description provided.