Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change return type of generated setters to the message type #281

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Change return type of generated setters to the message type #281

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
51062fd
Update return type for set methods to reflect that they return the me…
craigatron Jun 21, 2021
6a8f2e7
Add tests
craigatron Jun 21, 2021
e8ff4e3
Fix return type for clear methods and repeated primitive field adders.
craigatron Jun 25, 2021
4850763
Add tests for repeated message field add chaining.
craigatron Jul 12, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions examples/generated-grpc-js-node/proto/examplecom/annotations_pb.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,19 +5,19 @@ import * as jspb from "google-protobuf";

export class AnnotatedMessage extends jspb.Message {
getMyunit64(): string;
setMyunit64(value: string): void;
setMyunit64(value: string): AnnotatedMessage;

getMyint64(): string;
setMyint64(value: string): void;
setMyint64(value: string): AnnotatedMessage;

getMyfixed64(): string;
setMyfixed64(value: string): void;
setMyfixed64(value: string): AnnotatedMessage;

getMysint64(): string;
setMysint64(value: string): void;
setMysint64(value: string): AnnotatedMessage;

getMysfixed64(): string;
setMysfixed64(value: string): void;
setMysfixed64(value: string): AnnotatedMessage;

serializeBinary(): Uint8Array;
toObject(includeInstance?: boolean): AnnotatedMessage.AsObject;
Expand Down
10 changes: 5 additions & 5 deletions examples/generated-grpc-js-node/proto/examplecom/casing_pb.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,19 +5,19 @@ import * as jspb from "google-protobuf";

export class CasingMessage extends jspb.Message {
getTitlecase(): string;
setTitlecase(value: string): void;
setTitlecase(value: string): CasingMessage;

getCamelcase(): string;
setCamelcase(value: string): void;
setCamelcase(value: string): CasingMessage;

getSnakeCase(): string;
setSnakeCase(value: string): void;
setSnakeCase(value: string): CasingMessage;

getLeadingunderscorecamelcase(): string;
setLeadingunderscorecamelcase(value: string): void;
setLeadingunderscorecamelcase(value: string): CasingMessage;

getLeadingunderscoretitlecase(): string;
setLeadingunderscoretitlecase(value: string): void;
setLeadingunderscoretitlecase(value: string): CasingMessage;

serializeBinary(): Uint8Array;
toObject(includeInstance?: boolean): CasingMessage.AsObject;
Expand Down
8 changes: 4 additions & 4 deletions examples/generated-grpc-js-node/proto/examplecom/enum_message_pb.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,19 +6,19 @@ import * as proto_othercom_external_enum_pb from "../../proto/othercom/external_

export class EnumMessage extends jspb.Message {
getInternalEnum(): EnumMessage.InternalEnumMap[keyof EnumMessage.InternalEnumMap];
setInternalEnum(value: EnumMessage.InternalEnumMap[keyof EnumMessage.InternalEnumMap]): void;
setInternalEnum(value: EnumMessage.InternalEnumMap[keyof EnumMessage.InternalEnumMap]): EnumMessage;

clearInternalEnumsList(): void;
getInternalEnumsList(): Array<EnumMessage.InternalEnumMap[keyof EnumMessage.InternalEnumMap]>;
setInternalEnumsList(value: Array<EnumMessage.InternalEnumMap[keyof EnumMessage.InternalEnumMap]>): void;
setInternalEnumsList(value: Array<EnumMessage.InternalEnumMap[keyof EnumMessage.InternalEnumMap]>): EnumMessage;
addInternalEnums(value: EnumMessage.InternalEnumMap[keyof EnumMessage.InternalEnumMap], index?: number): EnumMessage.InternalEnumMap[keyof EnumMessage.InternalEnumMap];

getExternalEnum(): proto_othercom_external_enum_pb.ExternalEnumMap[keyof proto_othercom_external_enum_pb.ExternalEnumMap];
setExternalEnum(value: proto_othercom_external_enum_pb.ExternalEnumMap[keyof proto_othercom_external_enum_pb.ExternalEnumMap]): void;
setExternalEnum(value: proto_othercom_external_enum_pb.ExternalEnumMap[keyof proto_othercom_external_enum_pb.ExternalEnumMap]): EnumMessage;

clearExternalEnumsList(): void;
getExternalEnumsList(): Array<proto_othercom_external_enum_pb.ExternalEnumMap[keyof proto_othercom_external_enum_pb.ExternalEnumMap]>;
setExternalEnumsList(value: Array<proto_othercom_external_enum_pb.ExternalEnumMap[keyof proto_othercom_external_enum_pb.ExternalEnumMap]>): void;
setExternalEnumsList(value: Array<proto_othercom_external_enum_pb.ExternalEnumMap[keyof proto_othercom_external_enum_pb.ExternalEnumMap]>): EnumMessage;
addExternalEnums(value: proto_othercom_external_enum_pb.ExternalEnumMap[keyof proto_othercom_external_enum_pb.ExternalEnumMap], index?: number): proto_othercom_external_enum_pb.ExternalEnumMap[keyof proto_othercom_external_enum_pb.ExternalEnumMap];

serializeBinary(): Uint8Array;
Expand Down
4 changes: 2 additions & 2 deletions examples/generated-grpc-js-node/proto/examplecom/extensions_pb.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ export class ExtensionMessage extends jspb.Message {
hasMyExtensionString(): boolean;
clearMyExtensionString(): void;
getMyExtensionString(): string | undefined;
setMyExtensionString(value: string): void;
setMyExtensionString(value: string): ExtensionMessage;

serializeBinary(): Uint8Array;
toObject(includeInstance?: boolean): ExtensionMessage.AsObject;
Expand All @@ -29,7 +29,7 @@ export class MyBase extends jspb.Message {
hasMyBaseString(): boolean;
clearMyBaseString(): void;
getMyBaseString(): string | undefined;
setMyBaseString(value: string): void;
setMyBaseString(value: string): MyBase;

serializeBinary(): Uint8Array;
toObject(includeInstance?: boolean): MyBase.AsObject;
Expand Down
4 changes: 2 additions & 2 deletions examples/generated-grpc-js-node/proto/examplecom/getter_name_pb.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,14 +7,14 @@ export class GetterNameConflictMessage extends jspb.Message {
hasExtension$(): boolean;
clearExtension$(): void;
getExtension$(): string | undefined;
setExtension$(value: string): void;
setExtension$(value: string): GetterNameConflictMessage;

hasJsPbMessageId$(): boolean;
clearJsPbMessageId$(): void;
getJsPbMessageId$(): Uint8Array | string;
getJsPbMessageId_asU8(): Uint8Array;
getJsPbMessageId_asB64(): string;
setJsPbMessageId$(value: Uint8Array | string): void;
setJsPbMessageId$(value: Uint8Array | string): GetterNameConflictMessage;

serializeBinary(): Uint8Array;
toObject(includeInstance?: boolean): GetterNameConflictMessage.AsObject;
Expand Down
2 changes: 1 addition & 1 deletion examples/generated-grpc-js-node/proto/examplecom/map_message_pb.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ export namespace MapMessage {

export class InternalChildMessage extends jspb.Message {
getMyString(): string;
setMyString(value: string): void;
setMyString(value: string): InternalChildMessage;

serializeBinary(): Uint8Array;
toObject(includeInstance?: boolean): InternalChildMessage.AsObject;
Expand Down
18 changes: 9 additions & 9 deletions examples/generated-grpc-js-node/proto/examplecom/oneof_message_pb.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,22 +8,22 @@ export class OneOfMessage extends jspb.Message {
hasInternalChildMessage(): boolean;
clearInternalChildMessage(): void;
getInternalChildMessage(): OneOfMessage.InternalChildMessage | undefined;
setInternalChildMessage(value?: OneOfMessage.InternalChildMessage): void;
setInternalChildMessage(value?: OneOfMessage.InternalChildMessage): OneOfMessage;

hasExternalChildMessage(): boolean;
clearExternalChildMessage(): void;
getExternalChildMessage(): proto_othercom_external_child_message_pb.ExternalChildMessage | undefined;
setExternalChildMessage(value?: proto_othercom_external_child_message_pb.ExternalChildMessage): void;
setExternalChildMessage(value?: proto_othercom_external_child_message_pb.ExternalChildMessage): OneOfMessage;

hasMyString(): boolean;
clearMyString(): void;
getMyString(): string;
setMyString(value: string): void;
setMyString(value: string): OneOfMessage;

hasMyInt64(): boolean;
clearMyInt64(): void;
getMyInt64(): number;
setMyInt64(value: number): void;
setMyInt64(value: number): OneOfMessage;

getGroupCase(): OneOfMessage.GroupCase;
serializeBinary(): Uint8Array;
Expand All @@ -46,7 +46,7 @@ export namespace OneOfMessage {

export class InternalChildMessage extends jspb.Message {
getMyString(): string;
setMyString(value: string): void;
setMyString(value: string): InternalChildMessage;

serializeBinary(): Uint8Array;
toObject(includeInstance?: boolean): InternalChildMessage.AsObject;
Expand Down Expand Up @@ -77,12 +77,12 @@ export class CamelCasedOneOfMessage extends jspb.Message {
hasAnint(): boolean;
clearAnint(): void;
getAnint(): number;
setAnint(value: number): void;
setAnint(value: number): CamelCasedOneOfMessage;

hasThestring(): boolean;
clearThestring(): void;
getThestring(): string;
setThestring(value: string): void;
setThestring(value: string): CamelCasedOneOfMessage;

getCamelcasedmessageCase(): CamelCasedOneOfMessage.CamelcasedmessageCase;
serializeBinary(): Uint8Array;
Expand Down Expand Up @@ -112,12 +112,12 @@ export class SnakeCasedOneOfMessage extends jspb.Message {
hasAnint(): boolean;
clearAnint(): void;
getAnint(): number;
setAnint(value: number): void;
setAnint(value: number): SnakeCasedOneOfMessage;

hasThestring(): boolean;
clearThestring(): void;
getThestring(): string;
setThestring(value: string): void;
setThestring(value: string): SnakeCasedOneOfMessage;

getSnakeCasedMessageCase(): SnakeCasedOneOfMessage.SnakeCasedMessageCase;
serializeBinary(): Uint8Array;
Expand Down
14 changes: 7 additions & 7 deletions examples/generated-grpc-js-node/proto/examplecom/parent_message_v2_pb.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,31 +8,31 @@ export class ParentMessageV2 extends jspb.Message {
hasInternalChildMessage(): boolean;
clearInternalChildMessage(): void;
getInternalChildMessage(): ParentMessageV2.InternalChildMessage;
setInternalChildMessage(value?: ParentMessageV2.InternalChildMessage): void;
setInternalChildMessage(value?: ParentMessageV2.InternalChildMessage): ParentMessageV2;

hasOptInternalChildMessage(): boolean;
clearOptInternalChildMessage(): void;
getOptInternalChildMessage(): ParentMessageV2.InternalChildMessage | undefined;
setOptInternalChildMessage(value?: ParentMessageV2.InternalChildMessage): void;
setOptInternalChildMessage(value?: ParentMessageV2.InternalChildMessage): ParentMessageV2;

clearInternalChildrenList(): void;
getInternalChildrenList(): Array<ParentMessageV2.InternalChildMessage>;
setInternalChildrenList(value: Array<ParentMessageV2.InternalChildMessage>): void;
setInternalChildrenList(value: Array<ParentMessageV2.InternalChildMessage>): ParentMessageV2;
addInternalChildren(value?: ParentMessageV2.InternalChildMessage, index?: number): ParentMessageV2.InternalChildMessage;

hasExternalChildMessage(): boolean;
clearExternalChildMessage(): void;
getExternalChildMessage(): proto_othercom_external_child_message_pb.ExternalChildMessage;
setExternalChildMessage(value?: proto_othercom_external_child_message_pb.ExternalChildMessage): void;
setExternalChildMessage(value?: proto_othercom_external_child_message_pb.ExternalChildMessage): ParentMessageV2;

hasOptExternalChildMessage(): boolean;
clearOptExternalChildMessage(): void;
getOptExternalChildMessage(): proto_othercom_external_child_message_pb.ExternalChildMessage | undefined;
setOptExternalChildMessage(value?: proto_othercom_external_child_message_pb.ExternalChildMessage): void;
setOptExternalChildMessage(value?: proto_othercom_external_child_message_pb.ExternalChildMessage): ParentMessageV2;

clearExternalChildrenList(): void;
getExternalChildrenList(): Array<proto_othercom_external_child_message_pb.ExternalChildMessage>;
setExternalChildrenList(value: Array<proto_othercom_external_child_message_pb.ExternalChildMessage>): void;
setExternalChildrenList(value: Array<proto_othercom_external_child_message_pb.ExternalChildMessage>): ParentMessageV2;
addExternalChildren(value?: proto_othercom_external_child_message_pb.ExternalChildMessage, index?: number): proto_othercom_external_child_message_pb.ExternalChildMessage;

serializeBinary(): Uint8Array;
Expand All @@ -59,7 +59,7 @@ export namespace ParentMessageV2 {
hasMyString(): boolean;
clearMyString(): void;
getMyString(): string | undefined;
setMyString(value: string): void;
setMyString(value: string): InternalChildMessage;

serializeBinary(): Uint8Array;
toObject(includeInstance?: boolean): InternalChildMessage.AsObject;
Expand Down
14 changes: 7 additions & 7 deletions examples/generated-grpc-js-node/proto/examplecom/parent_message_v3_pb.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,31 +8,31 @@ export class ParentMessageV3 extends jspb.Message {
hasInternalChildMessage(): boolean;
clearInternalChildMessage(): void;
getInternalChildMessage(): ParentMessageV3.InternalChildMessage | undefined;
setInternalChildMessage(value?: ParentMessageV3.InternalChildMessage): void;
setInternalChildMessage(value?: ParentMessageV3.InternalChildMessage): ParentMessageV3;

hasOptInternalChildMessage(): boolean;
clearOptInternalChildMessage(): void;
getOptInternalChildMessage(): ParentMessageV3.InternalChildMessage | undefined;
setOptInternalChildMessage(value?: ParentMessageV3.InternalChildMessage): void;
setOptInternalChildMessage(value?: ParentMessageV3.InternalChildMessage): ParentMessageV3;

clearInternalChildrenList(): void;
getInternalChildrenList(): Array<ParentMessageV3.InternalChildMessage>;
setInternalChildrenList(value: Array<ParentMessageV3.InternalChildMessage>): void;
setInternalChildrenList(value: Array<ParentMessageV3.InternalChildMessage>): ParentMessageV3;
addInternalChildren(value?: ParentMessageV3.InternalChildMessage, index?: number): ParentMessageV3.InternalChildMessage;

hasExternalChildMessage(): boolean;
clearExternalChildMessage(): void;
getExternalChildMessage(): proto_othercom_external_child_message_pb.ExternalChildMessage | undefined;
setExternalChildMessage(value?: proto_othercom_external_child_message_pb.ExternalChildMessage): void;
setExternalChildMessage(value?: proto_othercom_external_child_message_pb.ExternalChildMessage): ParentMessageV3;

hasOptExternalChildMessage(): boolean;
clearOptExternalChildMessage(): void;
getOptExternalChildMessage(): proto_othercom_external_child_message_pb.ExternalChildMessage | undefined;
setOptExternalChildMessage(value?: proto_othercom_external_child_message_pb.ExternalChildMessage): void;
setOptExternalChildMessage(value?: proto_othercom_external_child_message_pb.ExternalChildMessage): ParentMessageV3;

clearExternalChildrenList(): void;
getExternalChildrenList(): Array<proto_othercom_external_child_message_pb.ExternalChildMessage>;
setExternalChildrenList(value: Array<proto_othercom_external_child_message_pb.ExternalChildMessage>): void;
setExternalChildrenList(value: Array<proto_othercom_external_child_message_pb.ExternalChildMessage>): ParentMessageV3;
addExternalChildren(value?: proto_othercom_external_child_message_pb.ExternalChildMessage, index?: number): proto_othercom_external_child_message_pb.ExternalChildMessage;

serializeBinary(): Uint8Array;
Expand All @@ -57,7 +57,7 @@ export namespace ParentMessageV3 {

export class InternalChildMessage extends jspb.Message {
getMyString(): string;
setMyString(value: string): void;
setMyString(value: string): InternalChildMessage;

serializeBinary(): Uint8Array;
toObject(includeInstance?: boolean): InternalChildMessage.AsObject;
Expand Down
Loading