-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ability to disable user registration through environment variable #726
base: next
Are you sure you want to change the base?
Conversation
Signed-off-by: Aditya Pandey <[email protected]>
Signed-off-by: Aditya Pandey <[email protected]>
Signed-off-by: Aditya Pandey <[email protected]>
Signed-off-by: Aditya Pandey <[email protected]>
Signed-off-by: Aditya Pandey <[email protected]>
Thanks, @askadityapandey Awesome work! Everything seems fine, will review it today. |
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 47861e6. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution
Sent with 💌 from NxCloud. |
@askadityapandey Can you check here, https://github.com/implerhq/impler.io/actions/runs/10229623025/job/28387118233?pr=726#step:7:339 due to some linting issues, build is failing. Can you update it? |
Signed-off-by: Bhavik Chavda <[email protected]>
Signed-off-by: Aditya Pandey <[email protected]>
Signed-off-by: Aditya Pandey <[email protected]>
Hey @chavda-bhavik , see if it's fine now. |
This PR adds the ability to disable user registration through an environment variable
DISABLE_USER_REGISTRATION
. If this variable is set totrue
, the registration endpoint will return a403 Forbidden
status, preventing new users from signing up. This feature can be useful for instances where user registration needs to be temporarily or permanently disabled.Changes:
API Controller (
auth.controller.ts
):DISABLE_USER_REGISTRATION
in theregister
method to prevent user registration if the variable is set totrue
.Environment Validator (
env-validator.ts
):DISABLE_USER_REGISTRATION
environment variable to ensure it is correctly handled.Docker Compose (
docker-compose.yml
):DISABLE_USER_REGISTRATION
to theenvironment
section to allow configuration of the variable in self-hosted deployments.Also The project is cool, will look forward to contribute more <3
Fixes #724