fix planar error #414
Merged
fix planar error #414
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
src/layers/base_layer.jl
Outdated
Comment on lines
1
to
11
| @inline function apply_act(::typeof(identity), x::Any) | ||
| x | ||
| end | ||
|
|
||
| @inline function apply_act(activation::Any, x::Number) | ||
| activation(x) | ||
| end | ||
|
|
||
| @inline function apply_act(activation::Any, x::AbstractArray) | ||
| activation.(x) | ||
| end |
There was a problem hiding this comment.
[JuliaFormatter] reported by reviewdog 🐶
Suggested change
| @inline function apply_act(::typeof(identity), x::Any) | |
| x | |
| end | |
| @inline function apply_act(activation::Any, x::Number) | |
| activation(x) | |
| end | |
| @inline function apply_act(activation::Any, x::AbstractArray) | |
| activation.(x) | |
| end | |
| @inline function apply_act(::typeof(identity), x::Any) | |
| x | |
| end | |
| @inline function apply_act(activation::Any, x::Number) | |
| activation(x) | |
| end | |
| @inline function apply_act(activation::Any, x::AbstractArray) | |
| activation.(x) | |
| end |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #414 +/- ##
=======================================
Coverage 85.45% 85.45%
=======================================
Files 15 15
Lines 674 674
=======================================
Hits 576 576
Misses 98 98 ☔ View full report in Codecov by Sentry. |
src/layers/base_layer.jl
Outdated
Comment on lines
1
to
11
| @inline function apply_act(::typeof(identity), x::Union{Number, AbstractArray}) | ||
| x | ||
| end | ||
|
|
||
| @inline function apply_act(activation::Function, x::Number) | ||
| activation(x) | ||
| end | ||
|
|
||
| @inline function apply_act(activation::Function, x::AbstractArray) | ||
| activation.(x) | ||
| end |
There was a problem hiding this comment.
[JuliaFormatter] reported by reviewdog 🐶
Suggested change
| @inline function apply_act(::typeof(identity), x::Union{Number, AbstractArray}) | |
| x | |
| end | |
| @inline function apply_act(activation::Function, x::Number) | |
| activation(x) | |
| end | |
| @inline function apply_act(activation::Function, x::AbstractArray) | |
| activation.(x) | |
| end | |
| @inline function apply_act(::typeof(identity), x::Union{Number, AbstractArray}) | |
| x | |
| end | |
| @inline function apply_act(activation::Function, x::Number) | |
| activation(x) | |
| end | |
| @inline function apply_act(activation::Function, x::AbstractArray) | |
| activation.(x) | |
| end |
Benchmark resultJudge resultBenchmark Report for /home/runner/work/ContinuousNormalizingFlows.jl/ContinuousNormalizingFlows.jlJob Properties
ResultsA ratio greater than
Benchmark Group ListHere's a list of all the benchmark groups executed by this job:
Julia versioninfoTargetBaselineTarget resultBenchmark Report for /home/runner/work/ContinuousNormalizingFlows.jl/ContinuousNormalizingFlows.jlJob Properties
ResultsBelow is a table of this job's results, obtained by running the benchmarks.
Benchmark Group ListHere's a list of all the benchmark groups executed by this job:
Julia versioninfoBaseline resultBenchmark Report for /home/runner/work/ContinuousNormalizingFlows.jl/ContinuousNormalizingFlows.jlJob Properties
ResultsBelow is a table of this job's results, obtained by running the benchmarks.
Benchmark Group ListHere's a list of all the benchmark groups executed by this job:
Julia versioninfoRuntime information
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.