Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleaning & add MulLayer #390

Merged
merged 4 commits into from
Mar 27, 2024
Merged

Cleaning & add MulLayer #390

merged 4 commits into from
Mar 27, 2024

Conversation

prbzrg
Copy link
Member

@prbzrg prbzrg commented Mar 26, 2024

  • Cleaning
  • add MulLayer

src/cores/core.jl Show resolved Hide resolved
src/cores/core_cond_icnf.jl Show resolved Hide resolved
src/cores/core_icnf.jl Show resolved Hide resolved
src/layers/cond_layer.jl Outdated Show resolved Hide resolved
src/layers/mul_layer.jl Outdated Show resolved Hide resolved
src/layers/planar_layer.jl Outdated Show resolved Hide resolved
Copy link

codecov bot commented Mar 26, 2024

Codecov Report

Attention: Patch coverage is 76.35783% with 74 lines in your changes are missing coverage. Please review.

Project coverage is 87.32%. Comparing base (f999611) to head (365b10c).

Files Patch % Lines
src/cores/core_cond_icnf.jl 79.16% 20 Missing ⚠️
src/cores/core_icnf.jl 80.00% 18 Missing ⚠️
src/layers/planar_layer.jl 38.46% 16 Missing ⚠️
src/layers/mul_layer.jl 0.00% 11 Missing ⚠️
src/base_icnf.jl 90.00% 8 Missing ⚠️
src/cores/core.jl 85.71% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #390      +/-   ##
==========================================
+ Coverage   87.20%   87.32%   +0.12%     
==========================================
  Files          12       12              
  Lines         727      726       -1     
==========================================
  Hits          634      634              
+ Misses         93       92       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

src/layers/cond_layer.jl Outdated Show resolved Hide resolved
src/layers/mul_layer.jl Show resolved Hide resolved
src/layers/planar_layer.jl Show resolved Hide resolved
@prbzrg prbzrg changed the title Cleaning Cleaning & add MulLayer Mar 26, 2024
@prbzrg prbzrg self-assigned this Mar 26, 2024
src/layers/cond_layer.jl Show resolved Hide resolved
src/layers/mul_layer.jl Show resolved Hide resolved
Copy link
Contributor

Benchmark result

Judge result

Benchmark Report for /home/runner/work/ContinuousNormalizingFlows.jl/ContinuousNormalizingFlows.jl

Job Properties

  • Time of benchmarks:
    • Target: 27 Mar 2024 - 00:16
    • Baseline: 27 Mar 2024 - 00:41
  • Package commits:
    • Target: 23b689
    • Baseline: f99961
  • Julia commits:
    • Target: bd47ec
    • Baseline: bd47ec
  • Julia command flags:
    • Target: None
    • Baseline: None
  • Environment variables:
    • Target: None
    • Baseline: None

Results

A ratio greater than 1.0 denotes a possible regression (marked with ❌), while a ratio less
than 1.0 denotes a possible improvement (marked with ✅). Only significant results - results
that indicate possible regressions or improvements - are shown below (thus, an empty table means that all
benchmark results remained invariant between builds).

ID time ratio memory ratio
["main", "inplace", "AD-1-order", "train"] 1.02 (5%) 1.02 (1%) ❌

Benchmark Group List

Here's a list of all the benchmark groups executed by this job:

  • ["main", "inplace", "AD-1-order"]
  • ["main", "inplace", "direct"]
  • ["main", "no_inplace", "AD-1-order"]
  • ["main", "no_inplace", "direct"]

Julia versioninfo

Target

Julia Version 1.10.2
Commit bd47eca2c8a (2024-03-01 10:14 UTC)
Build Info:
  Official https://julialang.org/ release
Platform Info:
  OS: Linux (x86_64-linux-gnu)
      Ubuntu 22.04.4 LTS
  uname: Linux 6.5.0-1016-azure #16~22.04.1-Ubuntu SMP Fri Feb 16 15:42:02 UTC 2024 x86_64 x86_64
  CPU: AMD EPYC 7763 64-Core Processor: 
              speed         user         nice          sys         idle          irq
       #1  3197 MHz       6213 s          0 s        382 s      15335 s          0 s
       #2  2445 MHz      10976 s          0 s        362 s      10610 s          0 s
       #3  3257 MHz       5746 s          0 s        416 s      15774 s          0 s
       #4  3243 MHz       5650 s          0 s        443 s      15844 s          0 s
  Memory: 15.606498718261719 GB (12558.78125 MB free)
  Uptime: 2199.48 sec
  Load Avg:  1.03  1.02  1.09
  WORD_SIZE: 64
  LIBM: libopenlibm
  LLVM: libLLVM-15.0.7 (ORCJIT, znver3)
Threads: 1 default, 0 interactive, 1 GC (on 4 virtual cores)

Baseline

Julia Version 1.10.2
Commit bd47eca2c8a (2024-03-01 10:14 UTC)
Build Info:
  Official https://julialang.org/ release
Platform Info:
  OS: Linux (x86_64-linux-gnu)
      Ubuntu 22.04.4 LTS
  uname: Linux 6.5.0-1016-azure #16~22.04.1-Ubuntu SMP Fri Feb 16 15:42:02 UTC 2024 x86_64 x86_64
  CPU: AMD EPYC 7763 64-Core Processor: 
              speed         user         nice          sys         idle          irq
       #1  2445 MHz       9252 s          0 s        495 s      26833 s          0 s
       #2  2445 MHz      15692 s          0 s        488 s      20426 s          0 s
       #3  3261 MHz       8969 s          0 s        547 s      27072 s          0 s
       #4  3242 MHz       9332 s          0 s        592 s      26668 s          0 s
  Memory: 15.606498718261719 GB (12755.19921875 MB free)
  Uptime: 3667.25 sec
  Load Avg:  1.07  1.03  1.03
  WORD_SIZE: 64
  LIBM: libopenlibm
  LLVM: libLLVM-15.0.7 (ORCJIT, znver3)
Threads: 1 default, 0 interactive, 1 GC (on 4 virtual cores)

Target result

Benchmark Report for /home/runner/work/ContinuousNormalizingFlows.jl/ContinuousNormalizingFlows.jl

Job Properties

  • Time of benchmark: 27 Mar 2024 - 0:16
  • Package commit: 23b689
  • Julia commit: bd47ec
  • Julia command flags: None
  • Environment variables: None

Results

Below is a table of this job's results, obtained by running the benchmarks.
The values listed in the ID column have the structure [parent_group, child_group, ..., key], and can be used to
index into the BaseBenchmarks suite to retrieve the corresponding benchmarks.
The percentages accompanying time and memory values in the below table are noise tolerances. The "true"
time/memory value for a given benchmark is expected to fall within this percentage of the reported value.
An empty cell means that the value was zero.

ID time GC time memory allocations
["main", "inplace", "AD-1-order", "test"] 182.502 s (5%) 8.741 s 276.39 GiB (1%) 573818091
["main", "inplace", "AD-1-order", "train"] 30.753 s (5%) 1.267 s 38.60 GiB (1%) 111743743
["main", "inplace", "direct", "test"] 31.174 ms (5%) 53.68 MiB (1%) 108713
["main", "inplace", "direct", "train"] 5.145 ms (5%) 6.95 MiB (1%) 19366
["main", "no_inplace", "AD-1-order", "test"] 2.424 s (5%) 63.171 ms 1.32 GiB (1%) 7269096
["main", "no_inplace", "AD-1-order", "train"] 255.036 ms (5%) 6.371 ms 171.55 MiB (1%) 779054
["main", "no_inplace", "direct", "test"] 32.540 ms (5%) 60.99 MiB (1%) 111467
["main", "no_inplace", "direct", "train"] 6.383 ms (5%) 15.08 MiB (1%) 21814

Benchmark Group List

Here's a list of all the benchmark groups executed by this job:

  • ["main", "inplace", "AD-1-order"]
  • ["main", "inplace", "direct"]
  • ["main", "no_inplace", "AD-1-order"]
  • ["main", "no_inplace", "direct"]

Julia versioninfo

Julia Version 1.10.2
Commit bd47eca2c8a (2024-03-01 10:14 UTC)
Build Info:
  Official https://julialang.org/ release
Platform Info:
  OS: Linux (x86_64-linux-gnu)
      Ubuntu 22.04.4 LTS
  uname: Linux 6.5.0-1016-azure #16~22.04.1-Ubuntu SMP Fri Feb 16 15:42:02 UTC 2024 x86_64 x86_64
  CPU: AMD EPYC 7763 64-Core Processor: 
              speed         user         nice          sys         idle          irq
       #1  3197 MHz       6213 s          0 s        382 s      15335 s          0 s
       #2  2445 MHz      10976 s          0 s        362 s      10610 s          0 s
       #3  3257 MHz       5746 s          0 s        416 s      15774 s          0 s
       #4  3243 MHz       5650 s          0 s        443 s      15844 s          0 s
  Memory: 15.606498718261719 GB (12558.78125 MB free)
  Uptime: 2199.48 sec
  Load Avg:  1.03  1.02  1.09
  WORD_SIZE: 64
  LIBM: libopenlibm
  LLVM: libLLVM-15.0.7 (ORCJIT, znver3)
Threads: 1 default, 0 interactive, 1 GC (on 4 virtual cores)

Baseline result

Benchmark Report for /home/runner/work/ContinuousNormalizingFlows.jl/ContinuousNormalizingFlows.jl

Job Properties

  • Time of benchmark: 27 Mar 2024 - 0:41
  • Package commit: f99961
  • Julia commit: bd47ec
  • Julia command flags: None
  • Environment variables: None

Results

Below is a table of this job's results, obtained by running the benchmarks.
The values listed in the ID column have the structure [parent_group, child_group, ..., key], and can be used to
index into the BaseBenchmarks suite to retrieve the corresponding benchmarks.
The percentages accompanying time and memory values in the below table are noise tolerances. The "true"
time/memory value for a given benchmark is expected to fall within this percentage of the reported value.
An empty cell means that the value was zero.

ID time GC time memory allocations
["main", "inplace", "AD-1-order", "test"] 183.652 s (5%) 8.285 s 276.39 GiB (1%) 573818091
["main", "inplace", "AD-1-order", "train"] 30.285 s (5%) 1.276 s 37.82 GiB (1%) 109498483
["main", "inplace", "direct", "test"] 31.758 ms (5%) 53.68 MiB (1%) 108713
["main", "inplace", "direct", "train"] 5.105 ms (5%) 6.95 MiB (1%) 19366
["main", "no_inplace", "AD-1-order", "test"] 2.423 s (5%) 63.487 ms 1.32 GiB (1%) 7269096
["main", "no_inplace", "AD-1-order", "train"] 251.693 ms (5%) 6.190 ms 171.55 MiB (1%) 779054
["main", "no_inplace", "direct", "test"] 32.318 ms (5%) 60.99 MiB (1%) 111467
["main", "no_inplace", "direct", "train"] 6.438 ms (5%) 15.08 MiB (1%) 21814

Benchmark Group List

Here's a list of all the benchmark groups executed by this job:

  • ["main", "inplace", "AD-1-order"]
  • ["main", "inplace", "direct"]
  • ["main", "no_inplace", "AD-1-order"]
  • ["main", "no_inplace", "direct"]

Julia versioninfo

Julia Version 1.10.2
Commit bd47eca2c8a (2024-03-01 10:14 UTC)
Build Info:
  Official https://julialang.org/ release
Platform Info:
  OS: Linux (x86_64-linux-gnu)
      Ubuntu 22.04.4 LTS
  uname: Linux 6.5.0-1016-azure #16~22.04.1-Ubuntu SMP Fri Feb 16 15:42:02 UTC 2024 x86_64 x86_64
  CPU: AMD EPYC 7763 64-Core Processor: 
              speed         user         nice          sys         idle          irq
       #1  2445 MHz       9252 s          0 s        495 s      26833 s          0 s
       #2  2445 MHz      15692 s          0 s        488 s      20426 s          0 s
       #3  3261 MHz       8969 s          0 s        547 s      27072 s          0 s
       #4  3242 MHz       9332 s          0 s        592 s      26668 s          0 s
  Memory: 15.606498718261719 GB (12755.19921875 MB free)
  Uptime: 3667.25 sec
  Load Avg:  1.07  1.03  1.03
  WORD_SIZE: 64
  LIBM: libopenlibm
  LLVM: libLLVM-15.0.7 (ORCJIT, znver3)
Threads: 1 default, 0 interactive, 1 GC (on 4 virtual cores)

Runtime information

Runtime Info
BLAS #threads 2
BLAS.vendor() lbt
Sys.CPU_THREADS 4

lscpu output:

Architecture:                       x86_64
CPU op-mode(s):                     32-bit, 64-bit
Address sizes:                      48 bits physical, 48 bits virtual
Byte Order:                         Little Endian
CPU(s):                             4
On-line CPU(s) list:                0-3
Vendor ID:                          AuthenticAMD
Model name:                         AMD EPYC 7763 64-Core Processor
CPU family:                         25
Model:                              1
Thread(s) per core:                 2
Core(s) per socket:                 2
Socket(s):                          1
Stepping:                           1
BogoMIPS:                           4890.85
Flags:                              fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov pat pse36 clflush mmx fxsr sse sse2 ht syscall nx mmxext fxsr_opt pdpe1gb rdtscp lm constant_tsc rep_good nopl tsc_reliable nonstop_tsc cpuid extd_apicid aperfmperf pni pclmulqdq ssse3 fma cx16 pcid sse4_1 sse4_2 movbe popcnt aes xsave avx f16c rdrand hypervisor lahf_lm cmp_legacy svm cr8_legacy abm sse4a misalignsse 3dnowprefetch osvw topoext invpcid_single vmmcall fsgsbase bmi1 avx2 smep bmi2 erms invpcid rdseed adx smap clflushopt clwb sha_ni xsaveopt xsavec xgetbv1 xsaves clzero xsaveerptr rdpru arat npt nrip_save tsc_scale vmcb_clean flushbyasid decodeassists pausefilter pfthreshold v_vmsave_vmload umip vaes vpclmulqdq rdpid fsrm
Virtualization:                     AMD-V
Hypervisor vendor:                  Microsoft
Virtualization type:                full
L1d cache:                          64 KiB (2 instances)
L1i cache:                          64 KiB (2 instances)
L2 cache:                           1 MiB (2 instances)
L3 cache:                           32 MiB (1 instance)
NUMA node(s):                       1
NUMA node0 CPU(s):                  0-3
Vulnerability Gather data sampling: Not affected
Vulnerability Itlb multihit:        Not affected
Vulnerability L1tf:                 Not affected
Vulnerability Mds:                  Not affected
Vulnerability Meltdown:             Not affected
Vulnerability Mmio stale data:      Not affected
Vulnerability Retbleed:             Not affected
Vulnerability Spec rstack overflow: Vulnerable: Safe RET, no microcode
Vulnerability Spec store bypass:    Vulnerable
Vulnerability Spectre v1:           Mitigation; usercopy/swapgs barriers and __user pointer sanitization
Vulnerability Spectre v2:           Mitigation; Retpolines, STIBP disabled, RSB filling, PBRSB-eIBRS Not affected
Vulnerability Srbds:                Not affected
Vulnerability Tsx async abort:      Not affected
Cpu Property Value
Brand AMD EPYC 7763 64-Core Processor
Vendor :AMD
Architecture :Unknown
Model Family: 0xaf, Model: 0x01, Stepping: 0x01, Type: 0x00
Cores 16 physical cores, 16 logical cores (on executing CPU)
No Hyperthreading hardware capability detected
Clock Frequencies Not supported by CPU
Data Cache Level 1:3 : (32, 512, 32768) kbytes
64 byte cache line size
Address Size 48 bits virtual, 48 bits physical
SIMD 256 bit = 32 byte max. SIMD vector size
Time Stamp Counter TSC is accessible via rdtsc
TSC runs at constant rate (invariant from clock frequency)
Perf. Monitoring Performance Monitoring Counters (PMC) are not supported
Hypervisor Yes, Microsoft

@prbzrg prbzrg merged commit d160318 into main Mar 27, 2024
10 of 14 checks passed
@prbzrg prbzrg deleted the cleaning-33 branch March 27, 2024 00:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant