Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: migrate to SvelteKit app state #14807

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

chore: migrate to SvelteKit app state #14807

wants to merge 2 commits into from
+171 −136

Conversation

benmccann
Copy link
Contributor

bye bye stores!

alextran1502
alextran1502 approved these changes Dec 19, 2024
View reviewed changes
Copy link
Contributor

@alextran1502 alextran1502 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

danieldietzler
danieldietzler approved these changes Dec 19, 2024
View reviewed changes
Copy link
Member

@danieldietzler danieldietzler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noice! Could you fix the package-lock file?

@benmccann
Copy link
Contributor Author

Oh yeah. Good catch! Sorry I missed that. It's been updated now

@michelheusschen
Copy link
Contributor

Any reason not to migrate the remaining $app/stores instances?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danieldietzler danieldietzler danieldietzler approved these changes

@alextran1502 alextran1502 alextran1502 approved these changes

Assignees
No one assigned
Labels
changelog:skip 🖥️web
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@benmccann @michelheusschen @alextran1502 @danieldietzler