Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(web): transcoding settings cleanup #14765

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
+216 −196
Open

chore(web): transcoding settings cleanup #14765

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
dd69d18
rearrangement only
pyorot Dec 18, 2024
acd9d8b
add accordions (requiring new localisation keys)
pyorot Dec 18, 2024
bacc962
localisation string adjustments
pyorot Dec 18, 2024
06de970
capitalisation fix in existing code
pyorot Dec 18, 2024
fe631a9
suggestions from @mertalev + revert accidental EOF \n deletion
pyorot Dec 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions i18n/en.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -279,7 +279,7 @@
"transcoding_accepted_containers_description": "Select which container formats do not need to be remuxed to MP4. Only used for certain transcode policies.",
"transcoding_accepted_video_codecs": "Accepted video codecs",
"transcoding_accepted_video_codecs_description": "Select which video codecs do not need to be transcoded. Only used for certain transcode policies.",
"transcoding_advanced_options_description": "Options most users should not need to change",
"transcoding_advanced_options_description": "Encoding options most users should not need to change",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's nothing inherently specific to encoding about this section; it just happens to not have other settings at the moment.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fair; I'll revert this one. I'll drop my rationale for the change below:

I changed it to signpost that it's currently a continuation of encoding options, since I was worried about having some of those options outside the Encoding Options category. At first, I considered nesting Advanced under Encoding Options, but felt the flat structure is nicer aesthetically and less likely for settings to get lost. I also felt it unlikely there would ever be an advanced option not to do with encoding.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There was actually a tone-mapping option here until 1.120.0. There could be other niche options in the future as well, like setting frame rate or adding a custom flag to FFmpeg for debugging purposes.

Copy link
Contributor Author

@pyorot pyorot Dec 18, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah that last one isn't really to do with encoding. Currently, I have (or would have) the other two under encoding tho (were they not advanced); that's for later review.

"transcoding_audio_codec": "Audio codec",
"transcoding_audio_codec_description": "Opus is the highest quality option, but has lower compatibility with old devices or software.",
"transcoding_bitrate_description": "Videos higher than max bitrate or not in an accepted format",
Expand All @@ -289,6 +289,8 @@
"transcoding_constant_rate_factor": "Constant rate factor (-crf)",
"transcoding_constant_rate_factor_description": "Video quality level. Typical values are 23 for H.264, 28 for HEVC, 31 for VP9, and 35 for AV1. Lower is better, but produces larger files.",
"transcoding_disabled_description": "Don't transcode any videos, may break playback on some clients",
"transcoding_encoding_options": "Encoding Options",
"transcoding_encoding_options_description": "Set codecs, resolution, quality and other options for the encoded videos",
"transcoding_hardware_acceleration": "Hardware Acceleration",
"transcoding_hardware_acceleration_description": "Experimental; much faster, but will have lower quality at the same bitrate",
"transcoding_hardware_decoding": "Hardware decoding",
Expand All @@ -301,6 +303,8 @@
"transcoding_max_keyframe_interval": "Maximum keyframe interval",
"transcoding_max_keyframe_interval_description": "Sets the maximum frame distance between keyframes. Lower values worsen compression efficiency, but improve seek times and may improve quality in scenes with fast movement. 0 sets this value automatically.",
"transcoding_optimal_description": "Videos higher than target resolution or not in an accepted format",
"transcoding_policy": "Transcode Policy",
"transcoding_policy_description": "Set when a video will be transcoded",
"transcoding_preferred_hardware_device": "Preferred hardware device",
"transcoding_preferred_hardware_device_description": "Applies only to VAAPI and QSV. Sets the dri node used for hardware transcoding.",
"transcoding_preset_preset": "Preset (-preset)",
Expand All @@ -309,7 +313,7 @@
"transcoding_reference_frames_description": "The number of frames to reference when compressing a given frame. Higher values improve compression efficiency, but slow down encoding. 0 sets this value automatically.",
"transcoding_required_description": "Only videos not in an accepted format",
"transcoding_settings": "Video Transcoding Settings",
"transcoding_settings_description": "Manage the resolution and encoding information of the video files",
"transcoding_settings_description": "Manage which videos to transcode and how to encode them",
mertalev marked this conversation as resolved.
Show resolved Hide resolved
"transcoding_target_resolution": "Target resolution",
"transcoding_target_resolution_description": "Higher resolutions can preserve more detail but take longer to encode, have larger file sizes, and can reduce app responsiveness.",
"transcoding_temporal_aq": "Temporal AQ",
Expand All @@ -322,7 +326,7 @@
"transcoding_transcode_policy_description": "Policy for when a video should be transcoded. HDR videos will always be transcoded (except if transcoding is disabled).",
"transcoding_two_pass_encoding": "Two-pass encoding",
"transcoding_two_pass_encoding_setting_description": "Transcode in two passes to produce better encoded videos. When max bitrate is enabled (required for it to work with H.264 and HEVC), this mode uses a bitrate range based on the max bitrate and ignores CRF. For VP9, CRF can be used if max bitrate is disabled.",
"transcoding_video_codec": "Video Codec",
"transcoding_video_codec": "Video codec",
"transcoding_video_codec_description": "VP9 has high efficiency and web compatibility, but takes longer to transcode. HEVC performs similarly, but has lower web compatibility. H.264 is widely compatible and quick to transcode, but produces much larger files. AV1 is the most efficient codec but lacks support on older devices.",
"trash_enabled_description": "Enable Trash features",
"trash_number_of_days": "Number of days",
Expand Down Expand Up @@ -1337,4 +1341,4 @@
"yes": "Yes",
"you_dont_have_any_shared_links": "You don't have any shared links",
"zoom_image": "Zoom Image"
}
}
Loading
Loading