feat(web): delete all assets associated with stack on asset delete #14618
Conversation
| @@ -34,8 +37,36 @@ | |||
|
|
|||
| const handleDelete = async () => { | |||
| loading = true; | |||
| const ids = [...getOwnedAssets()].map((a) => a.id); | |||
| await deleteAssets(force, onAssetDelete, ids); | |||
| const ownedAssets = [...getOwnedAssets()]; | |||
There was a problem hiding this comment.
If you have 100,000 assets, will this populate 100,000 element array here?
|
I think it's worth deciding what the expected behavior should be when an asset in a stack in deleted or trashed and then we can determine the best way to accomplish that. One obvious thing we could change is that trashing the primary asset in a stack trashes the whole stack. In that case, I would expect that logic to exist server-side, not client-side. Also, ideally un-trashing the same asset would likewise untrash the whole stack. |
|
The sensible workflow is when you select the stack from the timeline; deleting them with the group of other single assets will also remove the stack. It is confusing at the moment when the said mechanism happens; you return to the timeline to find the stack is still there with only the top asset of the stack was removed In the detail viewer, there should be an option to remove the asset from the stack and a standard delete option to delete the stack. I agree with Jason that this mechanism should be handled from the server side. |
An attempt to fix this for the web: #13113
This change deletes both the stack, as well as all the asset ids for a given stack when deleted from either the asset screen, or the photos page.
I went with deleting the stack as I wasn't sure how to get show the stack in the trash page, and thought this was a workable solution. It does have the tradeoff that the user has to restack the images again.
I don't believe this is fully fleshed out yet, but I think the main idea is there.
It would be nice to have some pointers as for what other implications to consider for this PR as I'm not too familiar with the codebase.
I do believe that a query to grab all stack should be added, as opposed to how I have it now (fetch each stack).
I'm also wrapping around the deleteAssets as I'm not sure if this change should be propagated to other parts. The error handling can be improved.