Support numpy.bool_ dtype -> NativeBoolType #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gselzer
force-pushed
the
np-bool_-support
branch
from
3692e9c
to
a693da8
Compare
3 tasks
Specifically, we support conversion of np.ndarray objects of dtype np.bool8 to RandomAccessibleIntervals of NativeBoolType. Conversion going the other way is tricky, and is not fully tested by the work that this feature addition leans on
gselzer
force-pushed
the
np-bool_-support
branch
from
a693da8
to
269df0b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR supports the conversion from numpy arrays with
dtypenp.bool8toRandomAccessibleInterval<NativeBoolType>s, and adds a regression test to ensure this conversion is possible. (It actually adds more regression tests than that).This PR is the minimal possible change required to implement this functionality.
Conversion the other way is tricky, as we have discussed in #13, and the PRs that this work leans on are not enough to implement that conversion. The main issue lies in creating an Image of some
BooleanTypethat can be converted. I am unable to create anUnsafeImgof anyBooleanType, and although I can create anArrayImg<BitType>, I cannot convert that usingimglyb.to_numpy. Therefore, I leave that work for another PR.This PR requires the work of imglib/imglib2-unsafe#8 and imglib/imglib2-imglyb#10 to make their way into releases before this will work. I have tested locally with snapshots of each.