-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor/split kdtree #334
Conversation
for consistency, because the other NeighborSearch interfaces have copy() methods
I like the split of I reverted the split of |
I merged this into #333 |
I agree, splitting |
As discussed in #333, I made some attempt to refactor the implementation of
KDTree
. In particular:KDTreeValues
andKDTreePositions
, respectively), thereby also separating storage details of the positions fromKDTreeImpl
.KDTreeData
now is only a container providing easy access to data used in serialization.#(value backends) + #(position backends)
constructors instead of the#(value backends) * #(position backends)
constructors ofKDTreeData
before.The benchmarks with 1M points look very similar to those before the refactoring with slightly worse timings. Some of the difference, however, might be explained by my laptop's current temperature and power settings. Unfortunately, I don't have access to a more stable test hardware to do a proper comparison right now.
Although there are still a few rough edges, I am quite satisfied with how this turned out. In particular, the other searches work without adaptation and for the serialization experiments only very minor and obvious changes are necessary.
What do you think @tpietzsch ?