Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trimmed base percentage not correct for long read alignments #468

Open
jakobmatthes opened this issue Aug 4, 2023 · 1 comment
Open
Assignees

Comments

@jakobmatthes
Copy link
Collaborator

Calculation of trimmed base percentage assumes that all (most) alignments have the same length. For long read data, this is not valid. Reported trimmed base percentages are very high.

bases_trimmed += (max_length - al.length());

addQcValue(output, "QC:2000019", "trimmed base percentage", 100.0 * bases_trimmed / al_total / max_length);

@leonschuetz
Copy link
Collaborator

Does this parameter even make sense for long-read data? Because there is no adapter trimming (so far).
Should we simply remove it for long-reads?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants