Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Profile Screen #126

Merged
merged 38 commits into from
Feb 28, 2024
Merged

Profile Screen #126

merged 38 commits into from
Feb 28, 2024

Conversation

imashnake0
Copy link
Owner

@imashnake0 imashnake0 commented Feb 17, 2024 •
edited
Loading

Summary of changes:

  1. Added a basic banner layout.
  2. Use Compose Markdown to add user's about.
  3. Added tabs.

Tested changes:

I

@imashnake0
Use cache if available
15241f9 
Need to do this to stop triggering rate limits every couple minutes.
@imashnake0
Created a basic banner layout
2f28759
@imashnake0 imashnake0 added enhancement Enhancement feature New feature labels Feb 17, 2024
@imashnake0 imashnake0 self-assigned this Feb 17, 2024
@imashnake0
Copy link
Owner Author

Screenshot_20240218-041522.png

@imashnake0 imashnake0 linked an issue Feb 18, 2024 that may be closed by this pull request
Profile Screen #124
Closed
4 tasks
@imashnake0 imashnake0 changed the title Profile Profile Screen Feb 24, 2024
@imashnake0
Copy link
Owner Author

Screenshot_20240226-174033.png

@imashnake0
Copy link
Owner Author

Screenshot_20240226-234133.png

@imashnake0 imashnake0 marked this pull request as ready for review February 27, 2024 04:43
@imashnake0 imashnake0 requested a review from boswelja February 27, 2024 04:43
@imashnake0 imashnake0 mentioned this pull request Feb 27, 2024
Open
boswelja
boswelja requested changes Feb 27, 2024
View reviewed changes
api/anilist/src/main/kotlin/com/imashnake/animite/api/anilist/AnilistMediaRepository.kt Outdated Show resolved Hide resolved
app/src/main/java/com/imashnake/animite/features/home/HomeScreen.kt Show resolved Hide resolved
core/src/main/kotlin/com/imashnake/animite/core/extensions/MarkdownStyleExt.kt Show resolved Hide resolved
core/src/main/kotlin/com/imashnake/animite/core/extensions/MarkdownStyleExt.kt Show resolved Hide resolved
gradle/libs.versions.toml
@@ -79,6 +79,10 @@ junit = "4.13.2"
# https://github.com/detekt/detekt/releases.
detekt = "1.23.4"

# Compose Markdown
# https://github.com/boswelja/compose-markdown.
composeMarkdown = "1.0.3"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Brace for 1.0.4

profile/src/main/kotlin/com/imashnake/animite/profile/ProfileScreen.kt Show resolved Hide resolved
profile/src/main/kotlin/com/imashnake/animite/profile/ProfileScreen.kt Outdated Show resolved Hide resolved
profile/src/main/kotlin/com/imashnake/animite/profile/ProfileScreen.kt Outdated Show resolved Hide resolved
@imashnake0 imashnake0 requested a review from boswelja February 27, 2024 09:54
@imashnake0 imashnake0 merged commit fedf94c into main Feb 28, 2024
1 check passed
@imashnake0 imashnake0 deleted the profile branch February 28, 2024 00:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@boswelja boswelja boswelja approved these changes

Assignees

@imashnake0 imashnake0

Labels
enhancement Enhancement feature New feature
Projects
Roadmap
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Profile Screen
2 participants
@imashnake0 @boswelja