Added Miri to CI
#573
Merged
Added Miri to CI
#573
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cospectrum
commented
Apr 28, 2024
|
@cospectrum as there’s been a burst of activity in this repo recently and your change touches a lot of files, let’s merge this after fixing the current merge conflict rather. |
|
@theotherphil Conflict fixed, benches moved. |
|
Note: we want to ignore |
|
@cospectrum is this good to go or do you have more changes pending for this PR? |
You can merge |
|
Thanks a lot for all the work you’re doing getting a proper testing suite in place. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've separated all the tests and benchmarks where it makes sense.
benchesare ignored.UB detected in
nalgebra(Svd::try_new) andrayon(if feature is enabled), they are ignored.