Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#2373 feature add: Vertical Slice Architecture. #2828

Closed
wants to merge 17 commits into from

Conversation

sugan0tech
Copy link
Contributor

@sugan0tech sugan0tech commented Mar 10, 2024

Added the Vertical Slice Architecture #2373. previous PR: #2600

Copy link

sonarcloud bot commented Mar 10, 2024

Copy link
Owner

@iluwatar iluwatar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks very good already. Added a couple of minor comments that we need to address before merging.

vertical-slice-architecture/README.md Outdated Show resolved Hide resolved

> Similarly, in software development, vertical slice architecture involves organizing the codebase based on features.
> Each feature has its own self-contained set of components, making it easier to add, modify, or remove features without disrupting the entire application.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be possible to add a minimal code example here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

instead of code examples, can it be project file structure?

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I think we can improvise a bit here. Whatever describes the pattern most effectively.

Copy link

stale bot commented May 3, 2024

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the status: stale issues and pull requests that have not had recent interaction label May 3, 2024
@iluwatar
Copy link
Owner

iluwatar commented May 4, 2024

@sugan0tech some tests are failing and need to be fixed before merging

@stale stale bot removed the status: stale issues and pull requests that have not had recent interaction label May 4, 2024
Copy link

stale bot commented Jun 3, 2024

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the status: stale issues and pull requests that have not had recent interaction label Jun 3, 2024
@stale stale bot removed the status: stale issues and pull requests that have not had recent interaction label Jun 5, 2024
Copy link

stale bot commented Jul 5, 2024

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the status: stale issues and pull requests that have not had recent interaction label Jul 5, 2024
Copy link

stale bot commented Aug 19, 2024

Closed due to inactivity. Thank you for your contributions.

@stale stale bot closed this Aug 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: stale issues and pull requests that have not had recent interaction status: under review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants