Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md #2652

Merged
merged 4 commits into from
Mar 27, 2024
Merged

Update README.md #2652

merged 4 commits into from
Mar 27, 2024

Conversation

pushpander1010
Copy link
Contributor

Added explanation, programming example | Explanation for Half-Sync/Half-Async

Added a programmatic example and easy to understand explanation for Half-Sync/Half-Async design pattern.

For detailed contributing instructions see https://github.com/iluwatar/java-design-patterns/wiki/01.-How-to-contribute

@sonarcloud
Copy link

sonarcloud bot commented Oct 16, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@pushpander1010
Copy link
Contributor Author

Please merge it

Copy link

stale bot commented Nov 23, 2023

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the status: stale issues and pull requests that have not had recent interaction label Nov 23, 2023
Copy link
Owner

@iluwatar iluwatar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well written, but the explanation seems to be disconnected from the code example. I think that the explanation should be based on the actual code we have. Could you update accordingly?

@stale stale bot removed the status: stale issues and pull requests that have not had recent interaction label Dec 27, 2023
Copy link

stale bot commented Jan 26, 2024

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the status: stale issues and pull requests that have not had recent interaction label Jan 26, 2024
Copy link

stale bot commented Mar 12, 2024

Closed due to inactivity. Thank you for your contributions.

@stale stale bot closed this Mar 12, 2024
@iluwatar iluwatar reopened this Mar 17, 2024
@stale stale bot removed the status: stale issues and pull requests that have not had recent interaction label Mar 17, 2024
@iluwatar
Copy link
Owner

Looks good! Thank you for the contribution 🎉

@all-contributors please add @pushpander1010 for docs

Copy link
Contributor

@iluwatar

I couldn't determine any contributions to add, did you specify any contributions?
Please make sure to use valid contribution names.

I've put up a pull request to add @pushpander1010! 🎉

Copy link

sonarcloud bot commented Mar 17, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
C Reliability Rating on New Code (required ≥ A)
B Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

@iluwatar iluwatar merged commit 46fe841 into iluwatar:master Mar 27, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants