Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#392 added Notification Pattern #2629

Merged
merged 4 commits into from
Mar 9, 2024
Merged

#392 added Notification Pattern #2629

merged 4 commits into from
Mar 9, 2024

Conversation

sugan0tech
Copy link
Contributor

Pull request description

updated the requested old changes in the PR

For detailed contributing instructions see https://github.com/iluwatar/java-design-patterns/wiki/01.-How-to-contribute

@stale Stale
Copy link

stale bot commented Nov 9, 2023

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added status: stale issues and pull requests that have not had recent interaction and removed status: stale issues and pull requests that have not had recent interaction labels Nov 9, 2023
@sugan0tech sugan0tech force-pushed the sugan0tech/#392 branch 2 times, most recently from bc150d3 to ba5b559 Compare November 12, 2023 12:28
@sugan0tech sugan0tech marked this pull request as ready for review November 12, 2023 18:31
iluwatar
iluwatar requested changes Dec 2, 2023
View reviewed changes
notification/README.md Outdated Show resolved Hide resolved
pom.xml Outdated Show resolved Hide resolved
notification/src/main/java/com/iluwatar/RegisterWorker.java Show resolved Hide resolved
notification/src/main/java/com/iluwatar/RegisterWorker.java Outdated Show resolved Hide resolved
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Dec 30, 2023

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

6 New issues
0 Security Hotspots
98.8% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@stale Stale
Copy link

stale bot commented Jan 29, 2024

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the status: stale issues and pull requests that have not had recent interaction label Jan 29, 2024
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Mar 9, 2024

Quality Gate Passed Quality Gate passed

Issues
6 New issues
0 Accepted issues

Measures
0 Security Hotspots
98.8% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@iluwatar iluwatar merged commit 249efd1 into iluwatar:master Mar 9, 2024
1 check passed
@iluwatar
Copy link
Owner

iluwatar commented Mar 9, 2024

#393

@iluwatar
Copy link
Owner

iluwatar commented Mar 9, 2024

Looks good! Thank you for the contribution 🎉

@all-contributors please add @sugan0tech for code

@allcontributors allcontributors bot mentioned this pull request Mar 9, 2024
Merged
@allcontributors AllContributors
Copy link
Contributor

@iluwatar

I couldn't determine any contributions to add, did you specify any contributions?
Please make sure to use valid contribution names.

I've put up a pull request to add @sugan0tech! 🎉

@sugan0tech sugan0tech deleted the sugan0tech/#392 branch November 28, 2024 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iluwatar iluwatar iluwatar approved these changes

Assignees
No one assigned
Labels
status: stale issues and pull requests that have not had recent interaction status: under review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sugan0tech @iluwatar