Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added printstream instead of foreach #2599

Closed
wants to merge 1 commit into from
Closed

added printstream instead of foreach #2599

wants to merge 1 commit into from

Conversation

JayDhurat
Copy link

Pull request title

  • Clearly and concisely describes what it does
  • Refer to the issue that it solves, if available

Pull request description

  • Describes the main changes that come with the pull request
  • Any relevant additional information is provided

For detailed contributing instructions see https://github.com/iluwatar/java-design-patterns/wiki/01.-How-to-contribute

@sonarcloud
Copy link

sonarcloud bot commented Oct 2, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

iluwatar
iluwatar requested changes Oct 14, 2023
View reviewed changes
Copy link
Owner

@iluwatar iluwatar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Parallel stream is not desired here. Often the overhead slows the code down and due to the parallel execution the prints may come out of order.

See https://www.baeldung.com/java-when-to-use-parallel-stream

@iluwatar iluwatar closed this Oct 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iluwatar iluwatar iluwatar requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JayDhurat @iluwatar