Resolving conflicts with @raymanfx upsteam and adding @anatawa12 changes and an offset fix. #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Actually print the format in use when saying so instead of printing the requested format.
Bump minor versions and push to crates.io Signed-off-by: Christopher N. Hesse <[email protected]>
Signed-off-by: Christopher N. Hesse <[email protected]>
Signed-off-by: Christopher N. Hesse <[email protected]>
CI throws an `clippy::bad_bit_mask` that has been fixed in `bitflags 2` [1], and it is always a good idea to stay up to date with the latest crate releases. The major change is an internal restructuring into _two_ types, that require the user to now re-expose default traits implemented on the inner type to the outer type by `#[derive]`'ing them. [1]: bitflags/bitflags#373
* refactor to avoid extra ioctl remove old control getter * fix doc link and clippy lint * inline format args to please our pedantic overlords * Add missing backticks around intradoc link * Revert "inline format args to please our pedantic overlords" This reverts commit 8ba7d19. * Drop unneeded `control_from_id()` The new implementation of `control()` takes a `&Description` directly, and callers have enough means to get that `Description` such that we shouldn't cater to the "slower" use-case of letting `libv4l-rs` query it again. --------- Co-authored-by: Marijn Suijten <[email protected]>
Upgrade to `bitflags 2`
raymanfx#80) `bitflags` intrinsically supports holding unknown flag values, and pretty-printing a non-zero hex code if there are any. This should make our conversion functions lossless and allow us/users to more easily spot new, unsupported constants.
Let dependabot suggest dependency upgrades in `Cargo.toml` and the GitHub Actions CI scripts so that we don't forget / miss out on them.
…aymanfx#84) Bumps [actions/checkout](https://github.com/actions/checkout) from 2 to 4. - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](actions/checkout@v2...v4) --- updated-dependencies: - dependency-name: actions/checkout dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…manfx#85) Updates the requirements on [jpeg-decoder](https://github.com/image-rs/jpeg-decoder) to permit the latest version. - [Changelog](https://github.com/image-rs/jpeg-decoder/blob/master/CHANGELOG.md) - [Commits](image-rs/jpeg-decoder@v0.2.1...v0.3.0) --- updated-dependencies: - dependency-name: jpeg-decoder dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…fx#87) Updates the requirements on [bindgen](https://github.com/rust-lang/rust-bindgen) to permit the latest version. - [Release notes](https://github.com/rust-lang/rust-bindgen/releases) - [Changelog](https://github.com/rust-lang/rust-bindgen/blob/main/CHANGELOG.md) - [Commits](rust-lang/rust-bindgen@v0.65.1...v0.69.1) --- updated-dependencies: - dependency-name: bindgen dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR should make raymanfx#71 able to merge with no conflicts, and it adds the changes from @anatawa12 with a tweak (the offset in addition to the length was needed in non-planer modes).