Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 侧边栏显示隐藏按钮,右边比左边高 #511

Merged
merged 3 commits into from
Sep 21, 2024

Conversation

tanlng
Copy link
Contributor

@tanlng tanlng commented Sep 18, 2024

贡献者你好

很高兴你能付出自己的时间参与到vue-fabric-editor的共享当中去,相信很多人都因为你提交的代码而收益。

原则

我们希望每次提交尽量小,较大重构除外,确保我们每次的改动影响范围清晰明了,能够方便项目维护者快速的将代码合并到主分支。

确保你的代码与主仓库没有冲突

在PR前,请确保你的代码与主仓库保持同步,可以参考这篇文章

确保你的代码代码能正常打包构建

在PR前,请在本地进行打包构建,并进行功能测试,确保功能正常,且不影响其他功能。

  • 代码构建正常

告知项目维护者本次修改的功能

  • 侧边栏显示隐藏按钮,右边比左边高

image

  • svg图片中写死了fill属性,导致不能继承上级颜色

@wuchenguang1998
Copy link
Member

感谢pr,有时间的话可以用下vscode的prettier插件,提交修复下这两个文件的格式错误吗
image

@tanlng
Copy link
Contributor Author

tanlng commented Sep 21, 2024

感谢pr,有时间的话可以用下vscode的prettier插件,提交修复下这两个文件的格式错误吗 image

已经修复了

@wuchenguang1998 wuchenguang1998 merged commit 4d856a8 into ikuaitu:main Sep 21, 2024
1 check passed
@wuchenguang1998
Copy link
Member

感谢PR,已合并

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants