Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add tests and examples for mem.Pool #324

Merged
merged 3 commits into from
Apr 20, 2024
Merged

chore: add tests and examples for mem.Pool #324

merged 3 commits into from
Apr 20, 2024

Conversation

KEINOS
Copy link
Contributor

@KEINOS KEINOS commented Apr 20, 2024

This PR adds tests and examples for mem package under tokenizer/lattice/mem.

This is part of #277 and #299 but using ExampleXxx() in the test and should display an example in the godoc.

@ikawaha ikawaha changed the base branch from v2 to develop April 20, 2024 05:50
@ikawaha ikawaha self-requested a review April 20, 2024 05:52
ikawaha
ikawaha approved these changes Apr 20, 2024
View reviewed changes
Copy link
Owner

@ikawaha ikawaha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch! Thank you!

@ikawaha ikawaha merged commit 08386d5 into ikawaha:develop Apr 20, 2024
7 checks passed
@KEINOS KEINOS deleted the add-tests-for-memPool branch April 20, 2024 05:53
@KEINOS
Copy link
Contributor Author

KEINOS commented Apr 22, 2024

https://pkg.go.dev/github.com/ikawaha/kagome/[email protected]/tokenizer/lattice/mem#pkg-examples

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ikawaha ikawaha ikawaha approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@KEINOS @ikawaha