(WIP) Scala 3 cross compile #158
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
To be completely honest I don't even use this. It's a dependency of a test dependency of a dependency that I can do without, this is just for fun really. I was pretty hesitant even to open the WIP for that reason but I'd put a few hours in and thought I'd gauge if there was any interest, in which case I might pursue this, if only as an excuse to fiddle with scala 3 macros a bit more. I won't be salty if this pr is closed with a 'won't fix' or whatever - not least because I'm aware how glaringly incomplete it is as a PR and because as it stands it would change the API |
|
I think a more worthwhile endeavor might be PR to help your test dependency
to migrate away from ficus. I have a gut feeling that it will take less
effort. Ficus depends on scala-reflect which is not supported by scala 3
…On Sun, Aug 15, 2021, 3:55 PM hughsimpson ***@***.***> wrote:
To be completely honest I don't even use this. It's a dependency of a test
dependency of a dependency, this is just for fun really
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#158 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAUKOKAPWTGV5YZZJ4JFEDT5ALURANCNFSM5CELKK5A>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The innocuous bits:
Lots of things still to figure out:
.as[Foo]("configObjectName")directly without casting first. This might be a dotty bug, I haven't minimised it yetEdit: this turns out to actually be a conflict with this test lib: where
asis defined in a trait it's overriding the import, so we're seeing errors from the wrong method. Natural solution for now is probably to change the tests rsther than the API... (CF Methods available after implicit conversion are hidden by extension methods, even when signature does not match callsite scala/scala3#13300)toas a result. I doubt it really helpedEdit: it definitely did help, but since it's a conflict with implicits from tests only should be reverted (see above)
Would probably be sensible to take the scalafmt change and the syntactic restrictions as a single pr, and figure out how to make the macros work incrementally. I think I might forget about this, 'cause it's not even a direct dependency of mine, but thought it was only fair to show my working nonetheless. If there's any interest in this work I'm happy to split this pr up into mergeable and work-in-progress